[coreboot-gerrit] Change in ...coreboot[master]: mainboard/lenovo/t430s: Add ThinkPad T431s as a variant

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30021 )

Change subject: mainboard/lenovo/t430s: Add ThinkPad T431s as a variant
......................................................................


Patch Set 7:

(6 comments)

https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c 
File src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c:

https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c@92 
PS7, Line 92: 	                            combo Jack
code indent should use tabs where possible


https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c@93 
PS7, Line 93: 	               Master Port - Port B used for Jack Presence Detect
code indent should use tabs where possible


https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c@94 
PS7, Line 94: 	               Enable Combo Jack Detection */
code indent should use tabs where possible


https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c@124 
PS7, Line 124: 	0x02177a00, /* Digital PCBEEP Gain: 0h=-9db, 1h=-6db ... 4h=+3db, 5h=+6db */
line over 80 characters


https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/t430s/romstage.c 
File src/mainboard/lenovo/t430s/variants/t430s/romstage.c:

https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/t430s/romstage.c@57 
PS7, Line 57: void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
open brace '{' following function definitions go on the next line


https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/t430s/romstage.c@62 
PS7, Line 62: void mainboard_early_init(int s3resume) {
open brace '{' following function definitions go on the next line



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30021
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8062cacf5e8232405bb5757e1b1d063541f354a
Gerrit-Change-Number: 30021
Gerrit-PatchSet: 7
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Comment-Date: Tue, 04 Dec 2018 07:46:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181204/521f2ac9/attachment.html>