<p><a href="https://review.coreboot.org/c/coreboot/+/30021">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c">File src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c@92">Patch Set #7, Line 92:</a> <code style="font-family:monospace,monospace">                                    combo Jack</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c@93">Patch Set #7, Line 93:</a> <code style="font-family:monospace,monospace">                      Master Port - Port B used for Jack Presence Detect</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c@94">Patch Set #7, Line 94:</a> <code style="font-family:monospace,monospace">                   Enable Combo Jack Detection */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">code indent should use tabs where possible</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c@124">Patch Set #7, Line 124:</a> <code style="font-family:monospace,monospace">      0x02177a00, /* Digital PCBEEP Gain: 0h=-9db, 1h=-6db ... 4h=+3db, 5h=+6db */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/t430s/romstage.c">File src/mainboard/lenovo/t430s/variants/t430s/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/t430s/romstage.c@57">Patch Set #7, Line 57:</a> <code style="font-family:monospace,monospace">void mainboard_get_spd(spd_raw_data *spd, bool id_only) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">open brace '{' following function definitions go on the next line</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/t430s/romstage.c@62">Patch Set #7, Line 62:</a> <code style="font-family:monospace,monospace">void mainboard_early_init(int s3resume) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">open brace '{' following function definitions go on the next line</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30021">change 30021</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30021"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic8062cacf5e8232405bb5757e1b1d063541f354a </div>
<div style="display:none"> Gerrit-Change-Number: 30021 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Bill XIE <persmule@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Bill XIE <persmule@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 04 Dec 2018 07:46:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>