[coreboot-gerrit] Change in ...coreboot[master]: mb/google/poppy/variants/nami: update bard/ekko sku ids

Shelley Chen (Code Review) gerrit at coreboot.org
Tue Dec 4 07:27:20 CET 2018


Shelley Chen has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30031 )

Change subject: mb/google/poppy/variants/nami: update bard/ekko sku ids
......................................................................

mb/google/poppy/variants/nami: update bard/ekko sku ids

update the new sku ids of bard/ekko

BUG=b:120257865
BRANCH=Nami
TEST=emerge-nami coreboot chromeos-bootimage
     write the new sku id in cbi and verify the fw to
     check it can get the correct settings by the sku id

Change-Id: I3579d3d8042a270d8ea8e2f7b5612ff8e2cdfa7b
Signed-off-by: Ren Kuo <ren.kuo at quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/30031
Reviewed-by: Furquan Shaikh <furquan at google.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/mainboard/google/poppy/variants/nami/include/variant/sku.h
1 file changed, 9 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Ren Kuo: Looks good to me, but someone else must approve



diff --git a/src/mainboard/google/poppy/variants/nami/include/variant/sku.h b/src/mainboard/google/poppy/variants/nami/include/variant/sku.h
index 202622c..915039b 100644
--- a/src/mainboard/google/poppy/variants/nami/include/variant/sku.h
+++ b/src/mainboard/google/poppy/variants/nami/include/variant/sku.h
@@ -34,13 +34,14 @@
 #define SKU_1_SYNDRA	0x2BC62
 #define SKU_2_SYNDRA	0x2BC61
 #define SKU_3_SYNDRA	0X2BC60
-#define SKU_0_EKKO	0x118E3
-#define SKU_1_EKKO	0x18E3
-#define SKU_2_EKKO	0x118E1
-#define SKU_3_EKKO	0X18E1
-#define SKU_0_BARD	0x19CE3
-#define SKU_1_BARD	0x9CE3
-#define SKU_2_BARD	0x19CE1
-#define SKU_3_BARD	0X9CE1
+#define SKU_0_EKKO     0x10118E3
+#define SKU_1_EKKO     0x10018E3
+#define SKU_2_EKKO     0x10118E1
+#define SKU_3_EKKO     0X10018E1
+#define SKU_0_BARD     0x1019CE3
+#define SKU_1_BARD     0x1009CE3
+#define SKU_2_BARD     0x1019CE1
+#define SKU_3_BARD     0X1009CE1
+
 
 #endif /* __MAINBOARD_SKU_H__ */

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30031
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3579d3d8042a270d8ea8e2f7b5612ff8e2cdfa7b
Gerrit-Change-Number: 30031
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo <ren.kuo at quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo at quanta.corp-partner.google.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Vincent Wang <vwang at google.com>
Gerrit-Reviewer: YH Lin <yueherngl at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181204/b658dd16/attachment.html>


More information about the coreboot-gerrit mailing list