[coreboot-gerrit] Change in ...coreboot[master]: src: Remove unused variables

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29917 )

Change subject: src: Remove unused variables
......................................................................


Patch Set 15:

(4 comments)

https://review.coreboot.org/#/c/29917/15/src/cpu/amd/family_10h-family_15h/init_cpus.c 
File src/cpu/amd/family_10h-family_15h/init_cpus.c:

https://review.coreboot.org/#/c/29917/15/src/cpu/amd/family_10h-family_15h/init_cpus.c@1062 
PS15, Line 1062: !!
> It transforms nvram (any integer value, where 0 is meant to be false, and everything else is true) i […]
Yup, I've done this before. I would remove it then.


https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_baytrail/romstage/romstage.c 
File src/soc/intel/fsp_baytrail/romstage/romstage.c:

https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_baytrail/romstage/romstage.c@253 
PS15, Line 253: cbmem_was_initted
> You are right, but that will be some "crowded"  […]
Makes sense to not clutter this one, but for the other two cbmem_was_initted cases, the function call is roughly as long as the variable.


https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_broadwell_de/romstage/romstage.c 
File src/soc/intel/fsp_broadwell_de/romstage/romstage.c:

https://review.coreboot.org/#/c/29917/15/src/soc/intel/fsp_broadwell_de/romstage/romstage.c@119 
PS15, Line 119: cbmem_was_initted
> Oops, it shoild be '!cbmem_was_initted'
And this one too.


https://review.coreboot.org/#/c/29917/15/src/southbridge/intel/fsp_rangeley/romstage.c 
File src/southbridge/intel/fsp_rangeley/romstage.c:

https://review.coreboot.org/#/c/29917/15/src/southbridge/intel/fsp_rangeley/romstage.c@122 
PS15, Line 122: cbmem_was_initted
> sould be "!cbmem_was_initted"
In this one, I think replacing cbmem_was_initted with the function call is not going to clutter the code.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29917
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837
Gerrit-Change-Number: 29917
Gerrit-PatchSet: 15
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: David Guckian <david.guckian at intel.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Huang Jin <huang.jin at intel.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: York Yang <york.yang at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 03 Dec 2018 12:54:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes <ehaouas at noos.fr>
Comment-In-Reply-To: Angel Pons <th3fanbus at gmail.com>
Comment-In-Reply-To: Patrick Georgi <pgeorgi at google.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181203/8bb095c2/attachment.html>