[coreboot-gerrit] Change in ...coreboot[master]: src: Remove unused variables

Patrick Georgi (Code Review) gerrit at coreboot.org
Mon Dec 3 12:27:42 CET 2018


Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29917 )

Change subject: src: Remove unused variables
......................................................................


Patch Set 15:

(1 comment)

https://review.coreboot.org/#/c/29917/15/src/cpu/amd/family_10h-family_15h/init_cpus.c 
File src/cpu/amd/family_10h-family_15h/init_cpus.c:

https://review.coreboot.org/#/c/29917/15/src/cpu/amd/family_10h-family_15h/init_cpus.c@1062 
PS15, Line 1062: !!
> are you sure? […]
It transforms nvram (any integer value, where 0 is meant to be false, and everything else is true) into a bool (0 or 1). It's sometimes needed, when you then proceed to interpret the boolean value numerically, but not here.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29917
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837
Gerrit-Change-Number: 29917
Gerrit-PatchSet: 15
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: David Guckian <david.guckian at intel.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Huang Jin <huang.jin at intel.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: York Yang <york.yang at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 03 Dec 2018 11:27:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes <ehaouas at noos.fr>
Comment-In-Reply-To: Angel Pons <th3fanbus at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181203/aacd6f6d/attachment.html>


More information about the coreboot-gerrit mailing list