[coreboot-gerrit] Change in ...coreboot[master]: mainboard/lenovo: Add ThinkPad T431s

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30021 )

Change subject: mainboard/lenovo: Add ThinkPad T431s
......................................................................


Patch Set 1:

(16 comments)

https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/romstage.c 
File src/mainboard/lenovo/t431s/romstage.c:

https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/romstage.c@62 
PS1, Line 62: void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
open brace '{' following function definitions go on the next line


https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex 
File src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex:

https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex@1 
PS1, Line 1: 92 11 0b 03 04 00 00 01 03 52 01 08 0a 00 80 00 
trailing whitespace


https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex@2 
PS1, Line 2: 6e 78 6e 32 6e 11 18 81 20 08 3c 3c 00 f0 00 00 
trailing whitespace


https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex@3 
PS1, Line 3: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
trailing whitespace


https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex@4 
PS1, Line 4: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 65 00 
trailing whitespace


https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex@5 
PS1, Line 5: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
trailing whitespace


https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex@6 
PS1, Line 6: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
trailing whitespace


https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex@7 
PS1, Line 7: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
trailing whitespace


https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex@8 
PS1, Line 8: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 b6 3b 
trailing whitespace


https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex@9 
PS1, Line 9: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
trailing whitespace


https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex@10 
PS1, Line 10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
trailing whitespace


https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex@11 
PS1, Line 11: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
trailing whitespace


https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex@12 
PS1, Line 12: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
trailing whitespace


https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex@13 
PS1, Line 13: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
trailing whitespace


https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex@14 
PS1, Line 14: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
trailing whitespace


https://review.coreboot.org/#/c/30021/1/src/mainboard/lenovo/t431s/spd/samsung_4gb.spd.hex@15 
PS1, Line 15: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
trailing whitespace



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30021
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8062cacf5e8232405bb5757e1b1d063541f354a
Gerrit-Change-Number: 30021
Gerrit-PatchSet: 1
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 03 Dec 2018 12:20:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181203/75fdbb90/attachment.html>