[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/common/smihandler: Compile test CONFIG_ELOG_GSMI

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30013


Change subject: sb/intel/common/smihandler: Compile test CONFIG_ELOG_GSMI
......................................................................

sb/intel/common/smihandler: Compile test CONFIG_ELOG_GSMI

Change-Id: I2491c14c4fd45c74dbf584a07d6d3bf5ede7f69c
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/southbridge/intel/common/smihandler.c
1 file changed, 2 insertions(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/30013/1

diff --git a/src/southbridge/intel/common/smihandler.c b/src/southbridge/intel/common/smihandler.c
index bd3af3a..5a33dd5 100644
--- a/src/southbridge/intel/common/smihandler.c
+++ b/src/southbridge/intel/common/smihandler.c
@@ -244,7 +244,6 @@
 	return NULL;
 }
 
-#if IS_ENABLED(CONFIG_ELOG_GSMI)
 static void southbridge_smi_gsmi(void)
 {
 	u32 *ret, *param;
@@ -265,7 +264,6 @@
 	/* drivers/elog/gsmi.c */
 	*ret = gsmi_exec(sub_command, param);
 }
-#endif
 
 static void southbridge_smi_store(void)
 {
@@ -336,11 +334,10 @@
 		southbridge_finalize_all();
 		mainboard_finalized = 1;
 		break;
-#if IS_ENABLED(CONFIG_ELOG_GSMI)
 	case ELOG_GSMI_APM_CNT:
-		southbridge_smi_gsmi();
+		if (IS_ENABLED(CONFIG_ELOG_GSMI))
+			southbridge_smi_gsmi();
 		break;
-#endif
 	case SMMSTORE_APM_CNT:
 		if (IS_ENABLED(CONFIG_SMMSTORE))
 			southbridge_smi_store();

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30013
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2491c14c4fd45c74dbf584a07d6d3bf5ede7f69c
Gerrit-Change-Number: 30013
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181203/d721a44e/attachment.html>