<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30013">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sb/intel/common/smihandler: Compile test CONFIG_ELOG_GSMI<br><br>Change-Id: I2491c14c4fd45c74dbf584a07d6d3bf5ede7f69c<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/southbridge/intel/common/smihandler.c<br>1 file changed, 2 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/30013/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/southbridge/intel/common/smihandler.c b/src/southbridge/intel/common/smihandler.c</span><br><span>index bd3af3a..5a33dd5 100644</span><br><span>--- a/src/southbridge/intel/common/smihandler.c</span><br><span>+++ b/src/southbridge/intel/common/smihandler.c</span><br><span>@@ -244,7 +244,6 @@</span><br><span>   return NULL;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#if IS_ENABLED(CONFIG_ELOG_GSMI)</span><br><span> static void southbridge_smi_gsmi(void)</span><br><span> {</span><br><span>         u32 *ret, *param;</span><br><span>@@ -265,7 +264,6 @@</span><br><span>      /* drivers/elog/gsmi.c */</span><br><span>    *ret = gsmi_exec(sub_command, param);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span> </span><br><span> static void southbridge_smi_store(void)</span><br><span> {</span><br><span>@@ -336,11 +334,10 @@</span><br><span>                 southbridge_finalize_all();</span><br><span>          mainboard_finalized = 1;</span><br><span>             break;</span><br><span style="color: hsl(0, 100%, 40%);">-#if IS_ENABLED(CONFIG_ELOG_GSMI)</span><br><span>       case ELOG_GSMI_APM_CNT:</span><br><span style="color: hsl(0, 100%, 40%);">-         southbridge_smi_gsmi();</span><br><span style="color: hsl(120, 100%, 40%);">+               if (IS_ENABLED(CONFIG_ELOG_GSMI))</span><br><span style="color: hsl(120, 100%, 40%);">+                     southbridge_smi_gsmi();</span><br><span>              break;</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span>         case SMMSTORE_APM_CNT:</span><br><span>               if (IS_ENABLED(CONFIG_SMMSTORE))</span><br><span>                     southbridge_smi_store();</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30013">change 30013</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30013"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2491c14c4fd45c74dbf584a07d6d3bf5ede7f69c </div>
<div style="display:none"> Gerrit-Change-Number: 30013 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>