[coreboot-gerrit] Change in ...coreboot[master]: sb/amd/sr5650/cmn.h: Don't use device_t

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Sun Dec 2 21:41:36 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30007 )

Change subject: sb/amd/sr5650/cmn.h: Don't use device_t
......................................................................


Patch Set 1:

(6 comments)

https://review.coreboot.org/#/c/30007/1/src/southbridge/amd/sr5650/cmn.h 
File src/southbridge/amd/sr5650/cmn.h:

https://review.coreboot.org/#/c/30007/1/src/southbridge/amd/sr5650/cmn.h@185 
PS1, Line 185: 	if (reg != reg_old) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30007/1/src/southbridge/amd/sr5650/cmn.h@217 
PS1, Line 217: 	if (reg != reg_old) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30007/1/src/southbridge/amd/sr5650/cmn.h@229 
PS1, Line 229: 	if (reg != reg_old) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30007/1/src/southbridge/amd/sr5650/cmn.h@241 
PS1, Line 241: 	if (reg != reg_old) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30007/1/src/southbridge/amd/sr5650/cmn.h@253 
PS1, Line 253: 	if (reg != reg_old) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30007/1/src/southbridge/amd/sr5650/cmn.h@265 
PS1, Line 265: 	if (reg != reg_old) {
braces {} are not necessary for single statement blocks



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30007
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iddbec373bfb3f8dc208397727de32db3844a333a
Gerrit-Change-Number: 30007
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 02 Dec 2018 20:41:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181202/5239d22d/attachment.html>


More information about the coreboot-gerrit mailing list