[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Program HD Audio SVID/SSID

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29651 )

Change subject: soc/intel/cannonlake: Program HD Audio SVID/SSID
......................................................................


Patch Set 5:

(1 comment)

>> Is this just setting subsystem ids of a PCI device? These should be
>> set in the devicetree and no blob needed.
>>
>> If yes, this seems backwards. Shouldn't we set the id of the PCI
>> device first and when configuring the codec take the id of the PCI
>> device?
> 
> From https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/sound/pci/hda/patch_realtek.c?h=v4.20-rc4,
> line 651, we can see kernel driver is comparing the ssid with pci
> and verb.
>  
> ass = codec->core.subsystem_id & 0xffff;
> if (codec->bus->pci &&
> ass != codec->bus->pci->subsystem_device && (ass & 1))
> goto do_sku;

No need to quote the code, I already believed the commit message.

> 
> I believe the ssid of detail codec is fixed

It's been some years since I worked with audio codecs, IIRC, this
was writeable. Datasheet?

https://review.coreboot.org/#/c/29651/5/src/soc/intel/cannonlake/fsp_params.c 
File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/#/c/29651/5/src/soc/intel/cannonlake/fsp_params.c@132 
PS5, Line 132: 			params->SiSsidTablePtr = (uintptr_t)ssidtblptr;
If we are passing this to FSP, the struct has to be defined as part of
FSP's UPD headers, not by coreboot.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29651
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488
Gerrit-Change-Number: 29651
Gerrit-PatchSet: 5
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Jairaj Arava <jairaj.arava at intel.com>
Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Duncan Laurie <dlaurie at chromium.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Sat, 01 Dec 2018 12:01:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181201/68df6210/attachment.html>