<p style="white-space: pre-wrap; word-wrap: break-word;">>> Is this just setting subsystem ids of a PCI device? These should be<br>>> set in the devicetree and no blob needed.<br>>><br>>> If yes, this seems backwards. Shouldn't we set the id of the PCI<br>>> device first and when configuring the codec take the id of the PCI<br>>> device?<br>> <br>> From https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/sound/pci/hda/patch_realtek.c?h=v4.20-rc4,<br>> line 651, we can see kernel driver is comparing the ssid with pci<br>> and verb.<br>>  <br>> ass = codec->core.subsystem_id & 0xffff;<br>> if (codec->bus->pci &&<br>> ass != codec->bus->pci->subsystem_device && (ass & 1))<br>> goto do_sku;</p><p style="white-space: pre-wrap; word-wrap: break-word;">No need to quote the code, I already believed the commit message.</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;"><br>I believe the ssid of detail codec is fixed</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">It's been some years since I worked with audio codecs, IIRC, this<br>was writeable. Datasheet?</p><p><a href="https://review.coreboot.org/c/coreboot/+/29651">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29651/5/src/soc/intel/cannonlake/fsp_params.c">File src/soc/intel/cannonlake/fsp_params.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29651/5/src/soc/intel/cannonlake/fsp_params.c@132">Patch Set #5, Line 132:</a> <code style="font-family:monospace,monospace">                  params->SiSsidTablePtr = (uintptr_t)ssidtblptr;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If we are passing this to FSP, the struct has to be defined as part of<br>FSP's UPD headers, not by coreboot.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29651">change 29651</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29651"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488 </div>
<div style="display:none"> Gerrit-Change-Number: 29651 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jairaj Arava <jairaj.arava@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-CC: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 01 Dec 2018 12:01:33 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>