[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Fix Coverity Scan report

Lijian Zhao (Code Review) gerrit at coreboot.org
Fri Aug 31 19:24:07 CEST 2018


Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/28409


Change subject: soc/intel/cannonlake: Fix Coverity Scan report
......................................................................

soc/intel/cannonlake: Fix Coverity Scan report

Fix uninitialized variable OnModuleSpd, init bool with false first.

BUG=CID 1395330, 1395331
TEST=N/A

Change-Id: I050287370f7321ff9905937304bb3cc7f20d8c6a
Signed-off-by: Lijian Zhao <lijian.zhao at intel.com>
---
M src/soc/intel/cannonlake/cnl_memcfg_init.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/28409/1

diff --git a/src/soc/intel/cannonlake/cnl_memcfg_init.c b/src/soc/intel/cannonlake/cnl_memcfg_init.c
index 9f9592b..554fc28 100644
--- a/src/soc/intel/cannonlake/cnl_memcfg_init.c
+++ b/src/soc/intel/cannonlake/cnl_memcfg_init.c
@@ -98,7 +98,7 @@
 			const struct cnl_mb_cfg *cnl_cfg,
 			const struct spd_info *spd)
 {
-	bool OnModuleSpd;
+	bool OnModuleSpd = false;
 	/* Early Command Training Enabled */
 	mem_cfg->ECT = cnl_cfg->ect;
 	mem_cfg->DqPinsInterleaved = cnl_cfg->dq_pins_interleaved;

-- 
To view, visit https://review.coreboot.org/28409
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I050287370f7321ff9905937304bb3cc7f20d8c6a
Gerrit-Change-Number: 28409
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180831/513c3958/attachment.html>


More information about the coreboot-gerrit mailing list