[coreboot-gerrit] Change in coreboot[master]: drivers/vpd: Add VPD support

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25046 )

Change subject: drivers/vpd: Add VPD support
......................................................................


Patch Set 13:

(6 comments)

https://review.coreboot.org/#/c/25046/13/src/drivers/vpd/lib_vpd.c
File src/drivers/vpd/lib_vpd.c:

https://review.coreboot.org/#/c/25046/13/src/drivers/vpd/lib_vpd.c@79
PS13, Line 79: 		if (VPD_OK != decodeLen(max_len - *consumed,
suspect code indent for conditional statements (16, 32)


https://review.coreboot.org/#/c/25046/13/src/drivers/vpd/lib_vpd.c@79
PS13, Line 79: 		if (VPD_OK != decodeLen(max_len - *consumed,
Comparisons should place the constant on the right side of the test


https://review.coreboot.org/#/c/25046/13/src/drivers/vpd/lib_vpd.c@91
PS13, Line 91: 		if (VPD_OK != decodeLen(max_len - *consumed,
suspect code indent for conditional statements (16, 40)


https://review.coreboot.org/#/c/25046/13/src/drivers/vpd/lib_vpd.c@91
PS13, Line 91: 		if (VPD_OK != decodeLen(max_len - *consumed,
Comparisons should place the constant on the right side of the test


https://review.coreboot.org/#/c/25046/13/src/drivers/vpd/vpd.c
File src/drivers/vpd/vpd.c:

https://review.coreboot.org/#/c/25046/13/src/drivers/vpd/vpd.c@194
PS13, Line 194: 		while (VPD_OK == decodeVpdString(vpd->ro_size, vpd->blob,
Comparisons should place the constant on the right side of the test


https://review.coreboot.org/#/c/25046/13/src/drivers/vpd/vpd.c@200
PS13, Line 200: 		while (VPD_OK == decodeVpdString(vpd->rw_size,
Comparisons should place the constant on the right side of the test



-- 
To view, visit https://review.coreboot.org/25046
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9263bd39bf25d024e93daa57053fefcb1adc53a
Gerrit-Change-Number: 25046
Gerrit-PatchSet: 13
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Marcello Sylvester Bauer <info at marcellobauer.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 31 Aug 2018 13:59:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180831/1c882047/attachment.html>