[coreboot-gerrit] Change in coreboot[master]: acpi/gnvs: delay setting chromeos_apci_t.vdat until depthcharge

Joel Kitching (Code Review) gerrit at coreboot.org
Fri Aug 31 11:50:54 CEST 2018


Joel Kitching has uploaded this change for review. ( https://review.coreboot.org/28407


Change subject: acpi/gnvs: delay setting chromeos_apci_t.vdat until depthcharge
......................................................................

acpi/gnvs: delay setting chromeos_apci_t.vdat until depthcharge

Standardize on using vboot_handoff data structure for transferring
data between coreboot and depthcharge.  chromeos_acpi_t.vdat is
undefined until set in depthcharge.

BUG=b:112288216
TEST=compile and run on eve
CQ-DEPEND=CL:1198814

Change-Id: Iccc021334d3c6f0145dffd5ca05beb9e430378a9
Signed-off-by: Joel Kitching <kitching at gmail.com>
---
M src/vendorcode/google/chromeos/gnvs.c
1 file changed, 0 insertions(+), 6 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/28407/1

diff --git a/src/vendorcode/google/chromeos/gnvs.c b/src/vendorcode/google/chromeos/gnvs.c
index f21eb09..86ba4f3 100644
--- a/src/vendorcode/google/chromeos/gnvs.c
+++ b/src/vendorcode/google/chromeos/gnvs.c
@@ -37,12 +37,6 @@
 	/* Copy saved ME hash into NVS */
 	memcpy(chromeos_acpi->mehh, me_hash_saved, sizeof(chromeos_acpi->mehh));
 
-	struct vboot_handoff *vboot_handoff;
-
-	if (vboot_get_handoff_info((void **)&vboot_handoff, NULL) == 0)
-		memcpy(&chromeos_acpi->vdat[0], &vboot_handoff->shared_data[0],
-		       ARRAY_SIZE(chromeos_acpi->vdat));
-
 	chromeos_ram_oops_init(chromeos_acpi);
 }
 

-- 
To view, visit https://review.coreboot.org/28407
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iccc021334d3c6f0145dffd5ca05beb9e430378a9
Gerrit-Change-Number: 28407
Gerrit-PatchSet: 1
Gerrit-Owner: Joel Kitching <kitching at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180831/632501ad/attachment-0001.html>


More information about the coreboot-gerrit mailing list