<p>Joel Kitching has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28407">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">acpi/gnvs: delay setting chromeos_apci_t.vdat until depthcharge<br><br>Standardize on using vboot_handoff data structure for transferring<br>data between coreboot and depthcharge.  chromeos_acpi_t.vdat is<br>undefined until set in depthcharge.<br><br>BUG=b:112288216<br>TEST=compile and run on eve<br>CQ-DEPEND=CL:1198814<br><br>Change-Id: Iccc021334d3c6f0145dffd5ca05beb9e430378a9<br>Signed-off-by: Joel Kitching <kitching@gmail.com><br>---<br>M src/vendorcode/google/chromeos/gnvs.c<br>1 file changed, 0 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/28407/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vendorcode/google/chromeos/gnvs.c b/src/vendorcode/google/chromeos/gnvs.c</span><br><span>index f21eb09..86ba4f3 100644</span><br><span>--- a/src/vendorcode/google/chromeos/gnvs.c</span><br><span>+++ b/src/vendorcode/google/chromeos/gnvs.c</span><br><span>@@ -37,12 +37,6 @@</span><br><span>        /* Copy saved ME hash into NVS */</span><br><span>    memcpy(chromeos_acpi->mehh, me_hash_saved, sizeof(chromeos_acpi->mehh));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      struct vboot_handoff *vboot_handoff;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-    if (vboot_get_handoff_info((void **)&vboot_handoff, NULL) == 0)</span><br><span style="color: hsl(0, 100%, 40%);">-             memcpy(&chromeos_acpi->vdat[0], &vboot_handoff->shared_data[0],</span><br><span style="color: hsl(0, 100%, 40%);">-                  ARRAY_SIZE(chromeos_acpi->vdat));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>  chromeos_ram_oops_init(chromeos_acpi);</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28407">change 28407</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28407"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iccc021334d3c6f0145dffd5ca05beb9e430378a9 </div>
<div style="display:none"> Gerrit-Change-Number: 28407 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joel Kitching <kitching@google.com> </div>