[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge/peg: Add PEG driver

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20472 )

Change subject: nb/intel/sandybridge/peg: Add PEG driver
......................................................................


Patch Set 7:

(10 comments)

https://review.coreboot.org/#/c/20472/7/src/northbridge/intel/sandybridge/pcie.c
File src/northbridge/intel/sandybridge/pcie.c:

https://review.coreboot.org/#/c/20472/7/src/northbridge/intel/sandybridge/pcie.c@52
PS7, Line 52: static void pcie_programm_da0(device_t dev, u8 val)
'programm' may be misspelled - perhaps 'program'?


https://review.coreboot.org/#/c/20472/7/src/northbridge/intel/sandybridge/pcie.c@97
PS7, Line 97: static void pcie_programm_90x(device_t dev, u8 bundle, u8 a, u8 b)
'programm' may be misspelled - perhaps 'program'?


https://review.coreboot.org/#/c/20472/7/src/northbridge/intel/sandybridge/pcie.c@128
PS7, Line 128: 		/* Programm test values */
'Programm' may be misspelled - perhaps 'Program'?


https://review.coreboot.org/#/c/20472/7/src/northbridge/intel/sandybridge/pcie.c@129
PS7, Line 129: 		pcie_programm_90x(dev, bundle, a[i], i);
'programm' may be misspelled - perhaps 'program'?


https://review.coreboot.org/#/c/20472/7/src/northbridge/intel/sandybridge/pcie.c@138
PS7, Line 138: 		/* No errors occured after 100msec ? */
'occured' may be misspelled - perhaps 'occurred'?


https://review.coreboot.org/#/c/20472/7/src/northbridge/intel/sandybridge/pcie.c@177
PS7, Line 177: 	for (bundle = 0; bundle < end_bundle; bundle ++) {
space prohibited before that '++' (ctx:WxB)


https://review.coreboot.org/#/c/20472/7/src/northbridge/intel/sandybridge/pcie.c@190
PS7, Line 190: 			/* Programm 0xda0 */
'Programm' may be misspelled - perhaps 'Program'?


https://review.coreboot.org/#/c/20472/7/src/northbridge/intel/sandybridge/pcie.c@191
PS7, Line 191: 			pcie_programm_da0(dev, reg_da0[i]);
'programm' may be misspelled - perhaps 'program'?


https://review.coreboot.org/#/c/20472/7/src/northbridge/intel/sandybridge/pcie.c@226
PS7, Line 226: 		/* Programm 0xda0 */
'Programm' may be misspelled - perhaps 'Program'?


https://review.coreboot.org/#/c/20472/7/src/northbridge/intel/sandybridge/pcie.c@227
PS7, Line 227: 		pcie_programm_da0(dev, reg_da0[best_da0]);
'programm' may be misspelled - perhaps 'program'?



-- 
To view, visit https://review.coreboot.org/20472
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80a106b1f969103206f24dc5c4b268503acfa81f
Gerrit-Change-Number: 20472
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Dan Elkouby <streetwalkermc at gmail.com>
Gerrit-Reviewer: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 30 Aug 2018 14:44:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180830/5325fb12/attachment.html>