[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/Kconfig: Fix missing device node /dev/tpm0 for H1

Zhuohao Lee (Code Review) gerrit at coreboot.org
Thu Aug 30 14:33:35 CEST 2018


Zhuohao Lee has uploaded this change for review. ( https://review.coreboot.org/28400


Change subject: mb/google/poppy/Kconfig: Fix missing device node /dev/tpm0 for H1
......................................................................

mb/google/poppy/Kconfig: Fix missing device node /dev/tpm0 for H1

This patch adds the DRIVERS_SPI_ACPI to enable the tpm device node.
Without DRIVERS_SPI_ACPI, the kernel will popped out the below error:

cr50-update[592]: Starting cr50 update
cr50_get_name[595]: updater is /usr/sbin/gsctool -s
cr50-update[609]: exit status: 3
cr50-update[613]: output: Could not open TPM: No such file or directory
cr50_get_name[615]: board_id: '' board_flags: '0x', extension: 'prod'
cr50-update[617]: hashing /opt/google/cr50/firmware/cr50.bin.prod
cr50-update[678]: current state 3 in /var/cache/cr50.a3055efbc9.state
cr50-update[682]:  not running
cr50-result[782]: Not running normal image. Skip setting Board ID
trunksd[795]: TPM: Error opening tpm0 file descriptor at /dev/tpm0: No such file or directory

BUG=none
BRANCH=master
TEST=/dev/tpm0 is created

Change-Id: I35287c6c54299c2677c41fc830675570b9d45a94
Signed-off-by: Zhuohao Lee <zhuohao at chromium.org>
---
M src/mainboard/google/poppy/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/28400/1

diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig
index 1645451..df59c5e 100644
--- a/src/mainboard/google/poppy/Kconfig
+++ b/src/mainboard/google/poppy/Kconfig
@@ -196,6 +196,7 @@
 	select CHROMEOS_WIFI_SAR if CHROMEOS
 	select DRIVERS_I2C_MAX98927
 	select DRIVERS_I2C_DA7219
+	select DRIVERS_SPI_ACPI
 	select MAINBOARD_HAS_SPI_TPM_CR50
 
 config VARIANT_SPECIFIC_OPTIONS_SORAKA

-- 
To view, visit https://review.coreboot.org/28400
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I35287c6c54299c2677c41fc830675570b9d45a94
Gerrit-Change-Number: 28400
Gerrit-PatchSet: 1
Gerrit-Owner: Zhuohao Lee <zhuohao at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180830/d54a0adc/attachment.html>


More information about the coreboot-gerrit mailing list