<p>Zhuohao Lee has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28400">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/Kconfig: Fix missing device node /dev/tpm0 for H1<br><br>This patch adds the DRIVERS_SPI_ACPI to enable the tpm device node.<br>Without DRIVERS_SPI_ACPI, the kernel will popped out the below error:<br><br>cr50-update[592]: Starting cr50 update<br>cr50_get_name[595]: updater is /usr/sbin/gsctool -s<br>cr50-update[609]: exit status: 3<br>cr50-update[613]: output: Could not open TPM: No such file or directory<br>cr50_get_name[615]: board_id: '' board_flags: '0x', extension: 'prod'<br>cr50-update[617]: hashing /opt/google/cr50/firmware/cr50.bin.prod<br>cr50-update[678]: current state 3 in /var/cache/cr50.a3055efbc9.state<br>cr50-update[682]:  not running<br>cr50-result[782]: Not running normal image. Skip setting Board ID<br>trunksd[795]: TPM: Error opening tpm0 file descriptor at /dev/tpm0: No such file or directory<br><br>BUG=none<br>BRANCH=master<br>TEST=/dev/tpm0 is created<br><br>Change-Id: I35287c6c54299c2677c41fc830675570b9d45a94<br>Signed-off-by: Zhuohao Lee <zhuohao@chromium.org><br>---<br>M src/mainboard/google/poppy/Kconfig<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/28400/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig</span><br><span>index 1645451..df59c5e 100644</span><br><span>--- a/src/mainboard/google/poppy/Kconfig</span><br><span>+++ b/src/mainboard/google/poppy/Kconfig</span><br><span>@@ -196,6 +196,7 @@</span><br><span>        select CHROMEOS_WIFI_SAR if CHROMEOS</span><br><span>         select DRIVERS_I2C_MAX98927</span><br><span>  select DRIVERS_I2C_DA7219</span><br><span style="color: hsl(120, 100%, 40%);">+     select DRIVERS_SPI_ACPI</span><br><span>      select MAINBOARD_HAS_SPI_TPM_CR50</span><br><span> </span><br><span> config VARIANT_SPECIFIC_OPTIONS_SORAKA</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28400">change 28400</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28400"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I35287c6c54299c2677c41fc830675570b9d45a94 </div>
<div style="display:none"> Gerrit-Change-Number: 28400 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Zhuohao Lee <zhuohao@chromium.org> </div>