[coreboot-gerrit] Change in coreboot[master]: riscv: update mtime initialize

[Jonathan Neuschäfer (Code Review)]

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/28372 )

Change subject: riscv: update mtime initialize
......................................................................


Patch Set 1: Code-Review+1

(4 comments)

Thanks.

https://review.coreboot.org/#/c/28372/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/28372/1//COMMIT_MSG@7
PS1, Line 7: riscv: update mtime initialize
riscv: update mtime initialization


https://review.coreboot.org/#/c/28372/1/src/arch/riscv/mcall.c
File src/arch/riscv/mcall.c:

https://review.coreboot.org/#/c/28372/1/src/arch/riscv/mcall.c@40
PS1, Line 40: void mtime_init(void);
This function should also be declared in a header, so that SoC code can include that header and get type-checking for mtime_init.


https://review.coreboot.org/#/c/28372/1/src/arch/riscv/mcall.c@43
PS1, Line 43: __weak void mtime_init(void) { }
Consider adding a warning/error/die() message, for cases when this dummy implementation is called.


https://review.coreboot.org/#/c/28372/1/src/soc/sifive/fu540/Makefile.inc
File src/soc/sifive/fu540/Makefile.inc:

https://review.coreboot.org/#/c/28372/1/src/soc/sifive/fu540/Makefile.inc@19
PS1, Line 19: bootblock-y += clint.c
clint.c is not added in this commit



-- 
To view, visit https://review.coreboot.org/28372
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5524732f6eb3841e43afd176644119b03b5e5e27
Gerrit-Change-Number: 28372
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Shawn Chang <citypw at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 30 Aug 2018 09:53:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180830/089d020b/attachment.html>