<p style="white-space: pre-wrap; word-wrap: break-word;">Thanks.</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://review.coreboot.org/28372">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28372/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28372/1//COMMIT_MSG@7">Patch Set #1, Line 7:</a> <code style="font-family:monospace,monospace">riscv: update mtime initialize</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">riscv: update mtime initialization</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28372/1/src/arch/riscv/mcall.c">File src/arch/riscv/mcall.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28372/1/src/arch/riscv/mcall.c@40">Patch Set #1, Line 40:</a> <code style="font-family:monospace,monospace">void mtime_init(void);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This function should also be declared in a header, so that SoC code can include that header and get type-checking for mtime_init.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28372/1/src/arch/riscv/mcall.c@43">Patch Set #1, Line 43:</a> <code style="font-family:monospace,monospace">__weak void mtime_init(void) { }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Consider adding a warning/error/die() message, for cases when this dummy implementation is called.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28372/1/src/soc/sifive/fu540/Makefile.inc">File src/soc/sifive/fu540/Makefile.inc:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28372/1/src/soc/sifive/fu540/Makefile.inc@19">Patch Set #1, Line 19:</a> <code style="font-family:monospace,monospace">bootblock-y += clint.c</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">clint.c is not added in this commit</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28372">change 28372</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28372"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I5524732f6eb3841e43afd176644119b03b5e5e27 </div>
<div style="display:none"> Gerrit-Change-Number: 28372 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Xiang Wang <wxjstz@126.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer@gmx.net> </div>
<div style="display:none"> Gerrit-Reviewer: Shawn Chang <citypw@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 30 Aug 2018 09:53:49 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>