[coreboot-gerrit] Change in coreboot[master]: riscv: update misaligned memory access exception handling
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Thu Aug 30 09:28:48 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27972 )
Change subject: riscv: update misaligned memory access exception handling
......................................................................
Patch Set 20:
(5 comments)
https://review.coreboot.org/#/c/27972/20/src/arch/riscv/fp_asm.S
File src/arch/riscv/fp_asm.S:
https://review.coreboot.org/#/c/27972/20/src/arch/riscv/fp_asm.S@27
PS20, Line 27: /*
trailing whitespace
https://review.coreboot.org/#/c/27972/20/src/arch/riscv/misaligend.c
File src/arch/riscv/misaligend.c:
https://review.coreboot.org/#/c/27972/20/src/arch/riscv/misaligend.c@45
PS20, Line 45: /* opcode/mask used to identify instruction,
trailing whitespace
https://review.coreboot.org/#/c/27972/20/src/arch/riscv/misaligend.c@47
PS20, Line 47: uint32_t opcode;
trailing whitespace
https://review.coreboot.org/#/c/27972/20/src/arch/riscv/misaligend.c@142
PS20, Line 142: for(i = 0; i < ARRAY_SIZE(insn_info); i++)
space required before the open parenthesis '('
https://review.coreboot.org/#/c/27972/20/src/arch/riscv/misaligend.c@143
PS20, Line 143: if((insn_info[i].mask & insn) == insn_info[i].opcode)
space required before the open parenthesis '('
--
To view, visit https://review.coreboot.org/27972
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9983d56245eab1d458a84cb1432aeb805df7a49f
Gerrit-Change-Number: 27972
Gerrit-PatchSet: 20
Gerrit-Owner: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Hug <philipp at hug.cx>
Gerrit-Reviewer: Ronald G. Minnich <rminnich at gmail.com>
Gerrit-Reviewer: Shawn Chang <citypw at gmail.com>
Gerrit-Reviewer: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: ron minnich (1001188)
Gerrit-Comment-Date: Thu, 30 Aug 2018 07:28:48 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180830/74b6ef59/attachment.html>
More information about the coreboot-gerrit
mailing list