<p><a href="https://review.coreboot.org/27972">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27972/20/src/arch/riscv/fp_asm.S">File src/arch/riscv/fp_asm.S:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27972/20/src/arch/riscv/fp_asm.S@27">Patch Set #20, Line 27:</a> <code style="font-family:monospace,monospace">/* </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing whitespace</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27972/20/src/arch/riscv/misaligend.c">File src/arch/riscv/misaligend.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27972/20/src/arch/riscv/misaligend.c@45">Patch Set #20, Line 45:</a> <code style="font-family:monospace,monospace">/* opcode/mask used to identify instruction, </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27972/20/src/arch/riscv/misaligend.c@47">Patch Set #20, Line 47:</a> <code style="font-family:monospace,monospace">       uint32_t opcode; </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing whitespace</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27972/20/src/arch/riscv/misaligend.c@142">Patch Set #20, Line 142:</a> <code style="font-family:monospace,monospace">        for(i = 0; i < ARRAY_SIZE(insn_info); i++)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27972/20/src/arch/riscv/misaligend.c@143">Patch Set #20, Line 143:</a> <code style="font-family:monospace,monospace">         if((insn_info[i].mask & insn) == insn_info[i].opcode)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required before the open parenthesis '('</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27972">change 27972</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27972"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I9983d56245eab1d458a84cb1432aeb805df7a49f </div>
<div style="display:none"> Gerrit-Change-Number: 27972 </div>
<div style="display:none"> Gerrit-PatchSet: 20 </div>
<div style="display:none"> Gerrit-Owner: Xiang Wang <wxjstz@126.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer@gmx.net> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Hug <philipp@hug.cx> </div>
<div style="display:none"> Gerrit-Reviewer: Ronald G. Minnich <rminnich@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Shawn Chang <citypw@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Xiang Wang <wxjstz@126.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Reviewer: ron minnich (1001188) </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 30 Aug 2018 07:28:48 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>