[coreboot-gerrit] Change in coreboot[master]: riscv: add support for supervisor binary interface (SBI)

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28096 )

Change subject: riscv: add support for supervisor binary interface (SBI)
......................................................................


Patch Set 5:

(4 comments)

https://review.coreboot.org/#/c/28096/5/src/arch/riscv/sbi.c
File src/arch/riscv/sbi.c:

https://review.coreboot.org/#/c/28096/5/src/arch/riscv/sbi.c@29
PS5, Line 29: 	die("Please implement the \"set_msip\" function on your platform.");
Prefer using '"%s...", __func__' to using 'set_msip', this function's name, in a string


https://review.coreboot.org/#/c/28096/5/src/arch/riscv/sbi.c@83
PS5, Line 83: 		tf->gpr[10] = sbi_set_timer(tf->gpr[10] + ((uint64_t)tf->gpr[11] << 32));
line over 80 characters


https://review.coreboot.org/#/c/28096/5/src/arch/riscv/sbi.c@104
PS5, Line 104: 		tf->gpr[10] = send_ipi((uintptr_t *)tf->gpr[10], IPI_SFENCE_VMA);
line over 80 characters


https://review.coreboot.org/#/c/28096/5/src/arch/riscv/sbi.c@107
PS5, Line 107: 		tf->gpr[10] = send_ipi((uintptr_t *)tf->gpr[10], IPI_SFENCE_VMA_ASID);
line over 80 characters



-- 
To view, visit https://review.coreboot.org/28096
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c1f21d2f085f02208305dc4e3a0f970d400c27
Gerrit-Change-Number: 28096
Gerrit-PatchSet: 5
Gerrit-Owner: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Philipp Hug <philipp at hug.cx>
Gerrit-Reviewer: Ronald G. Minnich <rminnich at gmail.com>
Gerrit-Reviewer: Shawn Chang <citypw at gmail.com>
Gerrit-Reviewer: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: ron minnich (1001188)
Gerrit-Comment-Date: Thu, 30 Aug 2018 05:05:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180830/ed6efb52/attachment.html>