[coreboot-gerrit] Change in coreboot[master]: vendorcode/facebook: Add vendorcode

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/28351 )

Change subject: vendorcode/facebook: Add vendorcode
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/28351/1/src/vendorcode/facebook/Kconfig
File src/vendorcode/facebook/Kconfig:

https://review.coreboot.org/#/c/28351/1/src/vendorcode/facebook/Kconfig@27
PS1, Line 27: "Enables TIVA hard reset feature"
are you sure you don't want this in help instead of bool? Is this something you want to be able to select in menuconfig?


https://review.coreboot.org/#/c/28351/1/src/vendorcode/facebook/opencellular/reset.c
File src/vendorcode/facebook/opencellular/reset.c:

https://review.coreboot.org/#/c/28351/1/src/vendorcode/facebook/opencellular/reset.c@20
PS1, Line 20: void do_hard_reset(void)
            : {
            : }
Should it have an empty body?



-- 
To view, visit https://review.coreboot.org/28351
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I761ac3d1dcbab9dceb7a4c4f835ca8363680eb03
Gerrit-Change-Number: 28351
Gerrit-PatchSet: 1
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-CC: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Comment-Date: Mon, 27 Aug 2018 11:30:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180827/04ffe6b7/attachment.html>