<p><a href="https://review.coreboot.org/28351">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28351/1/src/vendorcode/facebook/Kconfig">File src/vendorcode/facebook/Kconfig:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28351/1/src/vendorcode/facebook/Kconfig@27">Patch Set #1, Line 27:</a> <code style="font-family:monospace,monospace">"Enables TIVA hard reset feature"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">are you sure you don't want this in help instead of bool? Is this something you want to be able to select in menuconfig?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28351/1/src/vendorcode/facebook/opencellular/reset.c">File src/vendorcode/facebook/opencellular/reset.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28351/1/src/vendorcode/facebook/opencellular/reset.c@20">Patch Set #1, Line 20:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">void do_hard_reset(void)<br>{<br>}<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should it have an empty body?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28351">change 28351</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28351"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I761ac3d1dcbab9dceb7a4c4f835ca8363680eb03 </div>
<div style="display:none"> Gerrit-Change-Number: 28351 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-CC: Werner Zeh <werner.zeh@siemens.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 27 Aug 2018 11:30:53 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>