[coreboot-gerrit] Change in coreboot[master]: intel/fsp2_0: Add FSP_NXT shared stack feature support

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Aug 27 10:41:46 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28358 )

Change subject: intel/fsp2_0: Add FSP_NXT shared stack feature support
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/28358/1/src/drivers/intel/fsp2_0/memory_init.c
File src/drivers/intel/fsp2_0/memory_init.c:

https://review.coreboot.org/#/c/28358/1/src/drivers/intel/fsp2_0/memory_init.c@173
PS1, Line 173: 	if (!IS_ENABLED(CONFIG_PLATFORM_USES_FSP_NXT))
that open brace { should be on the previous line


https://review.coreboot.org/#/c/28358/1/src/drivers/intel/fsp2_0/memory_init.c@178
PS1, Line 178: 		 * FSPM_UPD passed here is populated with default values provided by
line over 80 characters


https://review.coreboot.org/#/c/28358/1/src/drivers/intel/fsp2_0/memory_init.c@179
PS1, Line 179: 		 * the blob itself. We let FSPM use top of CAR region of the size it
line over 80 characters



-- 
To view, visit https://review.coreboot.org/28358
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6581111dbaddfa403eca14100577ccc8a05c4ec7
Gerrit-Change-Number: 28358
Gerrit-PatchSet: 1
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 27 Aug 2018 08:41:46 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180827/894c1ea9/attachment.html>


More information about the coreboot-gerrit mailing list