[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge/enable_usbdebug.c: Update pci_ehci_dbg_set_port()

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28341 )

Change subject: soc/amd/stoneyridge/enable_usbdebug.c: Update pci_ehci_dbg_set_port()
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/28341/1/src/soc/amd/stoneyridge/include/soc/southbridge.h
File src/soc/amd/stoneyridge/include/soc/southbridge.h:

https://review.coreboot.org/#/c/28341/1/src/soc/amd/stoneyridge/include/soc/southbridge.h@311
PS1, Line 311: #define   DEBUG_PORT_MASK		( BIT(16) | BIT(17) | (BIT(18) )
space prohibited after that open parenthesis '('


https://review.coreboot.org/#/c/28341/1/src/soc/amd/stoneyridge/include/soc/southbridge.h@311
PS1, Line 311: #define   DEBUG_PORT_MASK		( BIT(16) | BIT(17) | (BIT(18) )
space prohibited before that close parenthesis ')'


https://review.coreboot.org/#/c/28341/1/src/soc/amd/stoneyridge/include/soc/southbridge.h@311
PS1, Line 311: #define   DEBUG_PORT_MASK		( BIT(16) | BIT(17) | (BIT(18) )
Macros with complex values should be enclosed in parentheses



-- 
To view, visit https://review.coreboot.org/28341
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47b0e4450f96399fc3066d0a974e7a9324d82f90
Gerrit-Change-Number: 28341
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 24 Aug 2018 23:37:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180824/89543cf2/attachment.html>