<p><a href="https://review.coreboot.org/28341">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28341/1/src/soc/amd/stoneyridge/include/soc/southbridge.h">File src/soc/amd/stoneyridge/include/soc/southbridge.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28341/1/src/soc/amd/stoneyridge/include/soc/southbridge.h@311">Patch Set #1, Line 311:</a> <code style="font-family:monospace,monospace">#define   DEBUG_PORT_MASK           ( BIT(16) | BIT(17) | (BIT(18) )</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited after that open parenthesis '('</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28341/1/src/soc/amd/stoneyridge/include/soc/southbridge.h@311">Patch Set #1, Line 311:</a> <code style="font-family:monospace,monospace">#define   DEBUG_PORT_MASK               ( BIT(16) | BIT(17) | (BIT(18) )</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space prohibited before that close parenthesis ')'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28341/1/src/soc/amd/stoneyridge/include/soc/southbridge.h@311">Patch Set #1, Line 311:</a> <code style="font-family:monospace,monospace">#define   DEBUG_PORT_MASK             ( BIT(16) | BIT(17) | (BIT(18) )</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Macros with complex values should be enclosed in parentheses</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28341">change 28341</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28341"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I47b0e4450f96399fc3066d0a974e7a9324d82f90 </div>
<div style="display:none"> Gerrit-Change-Number: 28341 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 24 Aug 2018 23:37:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>