[coreboot-gerrit] Change in coreboot[master]: intel: Use common HPET table revision function

Marc Jones (Code Review) gerrit at coreboot.org
Thu Aug 23 05:47:09 CEST 2018


Marc Jones has uploaded this change for review. ( https://review.coreboot.org/28278


Change subject: intel: Use common HPET table revision function
......................................................................

intel: Use common HPET table revision function

Use get_acpi_table_revision(HPET) to keep all table versions in sync.

Change-Id: Idb5e8ccd49ec27f87a290f33c62df3c177645669
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/soc/intel/baytrail/acpi.c
M src/soc/intel/broadwell/acpi.c
M src/soc/intel/fsp_baytrail/acpi.c
M src/soc/intel/fsp_broadwell_de/acpi.c
M src/southbridge/intel/lynxpoint/acpi.c
5 files changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/28278/1

diff --git a/src/soc/intel/baytrail/acpi.c b/src/soc/intel/baytrail/acpi.c
index 31435f7..a43e6b6 100644
--- a/src/soc/intel/baytrail/acpi.c
+++ b/src/soc/intel/baytrail/acpi.c
@@ -147,7 +147,7 @@
 	memcpy(header->asl_compiler_id, ASLC, 4);
 
 	header->length = sizeof(acpi_hpet_t);
-	header->revision = 1;
+	header->revision = get_acpi_table_revision(HPET);
 
 	/* fill out HPET address */
 	addr->space_id = 0;	/* Memory */
diff --git a/src/soc/intel/broadwell/acpi.c b/src/soc/intel/broadwell/acpi.c
index af8e012..d826d43 100644
--- a/src/soc/intel/broadwell/acpi.c
+++ b/src/soc/intel/broadwell/acpi.c
@@ -200,7 +200,7 @@
 	memcpy(header->asl_compiler_id, ASLC, 4);
 
 	header->length = sizeof(acpi_hpet_t);
-	header->revision = 1;
+	header->revision = get_acpi_table_revision(HPET);
 
 	/* fill out HPET address */
 	addr->space_id = 0;	/* Memory */
diff --git a/src/soc/intel/fsp_baytrail/acpi.c b/src/soc/intel/fsp_baytrail/acpi.c
index f4dd545..97c8d5b 100644
--- a/src/soc/intel/fsp_baytrail/acpi.c
+++ b/src/soc/intel/fsp_baytrail/acpi.c
@@ -144,7 +144,7 @@
 	memcpy(header->asl_compiler_id, ASLC, 4);
 
 	header->length = sizeof(acpi_hpet_t);
-	header->revision = 1;
+	header->revision = get_acpi_table_revision(HPET);
 
 	/* fill out HPET address */
 	addr->space_id = 0;	/* Memory */
diff --git a/src/soc/intel/fsp_broadwell_de/acpi.c b/src/soc/intel/fsp_broadwell_de/acpi.c
index 9b64edc..5d65477 100644
--- a/src/soc/intel/fsp_broadwell_de/acpi.c
+++ b/src/soc/intel/fsp_broadwell_de/acpi.c
@@ -125,7 +125,7 @@
 	memcpy(header->asl_compiler_id, ASLC, 4);
 
 	header->length = sizeof(acpi_hpet_t);
-	header->revision = 1;
+	header->revision = get_acpi_table_revision(HPET);
 
 	/* fill out HPET address */
 	addr->space_id   = 0;	/* Memory */
diff --git a/src/southbridge/intel/lynxpoint/acpi.c b/src/southbridge/intel/lynxpoint/acpi.c
index 2a02744..7f6a5ad 100644
--- a/src/southbridge/intel/lynxpoint/acpi.c
+++ b/src/southbridge/intel/lynxpoint/acpi.c
@@ -36,7 +36,7 @@
 	memcpy(header->asl_compiler_id, ASLC, 4);
 
 	header->length = sizeof(acpi_hpet_t);
-	header->revision = 1;
+	header->revision = get_acpi_table_revision(HPET);
 
 	/* fill out HPET address */
 	addr->space_id = 0;	/* Memory */

-- 
To view, visit https://review.coreboot.org/28278
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb5e8ccd49ec27f87a290f33c62df3c177645669
Gerrit-Change-Number: 28278
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180823/f3ebd55a/attachment.html>


More information about the coreboot-gerrit mailing list