<p>Marc Jones has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28278">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">intel: Use common HPET table revision function<br><br>Use get_acpi_table_revision(HPET) to keep all table versions in sync.<br><br>Change-Id: Idb5e8ccd49ec27f87a290f33c62df3c177645669<br>Signed-off-by: Marc Jones <marcj303@gmail.com><br>---<br>M src/soc/intel/baytrail/acpi.c<br>M src/soc/intel/broadwell/acpi.c<br>M src/soc/intel/fsp_baytrail/acpi.c<br>M src/soc/intel/fsp_broadwell_de/acpi.c<br>M src/southbridge/intel/lynxpoint/acpi.c<br>5 files changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/28278/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/baytrail/acpi.c b/src/soc/intel/baytrail/acpi.c</span><br><span>index 31435f7..a43e6b6 100644</span><br><span>--- a/src/soc/intel/baytrail/acpi.c</span><br><span>+++ b/src/soc/intel/baytrail/acpi.c</span><br><span>@@ -147,7 +147,7 @@</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span> </span><br><span> header->length = sizeof(acpi_hpet_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(HPET);</span><br><span> </span><br><span> /* fill out HPET address */</span><br><span> addr->space_id = 0; /* Memory */</span><br><span>diff --git a/src/soc/intel/broadwell/acpi.c b/src/soc/intel/broadwell/acpi.c</span><br><span>index af8e012..d826d43 100644</span><br><span>--- a/src/soc/intel/broadwell/acpi.c</span><br><span>+++ b/src/soc/intel/broadwell/acpi.c</span><br><span>@@ -200,7 +200,7 @@</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span> </span><br><span> header->length = sizeof(acpi_hpet_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(HPET);</span><br><span> </span><br><span> /* fill out HPET address */</span><br><span> addr->space_id = 0; /* Memory */</span><br><span>diff --git a/src/soc/intel/fsp_baytrail/acpi.c b/src/soc/intel/fsp_baytrail/acpi.c</span><br><span>index f4dd545..97c8d5b 100644</span><br><span>--- a/src/soc/intel/fsp_baytrail/acpi.c</span><br><span>+++ b/src/soc/intel/fsp_baytrail/acpi.c</span><br><span>@@ -144,7 +144,7 @@</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span> </span><br><span> header->length = sizeof(acpi_hpet_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(HPET);</span><br><span> </span><br><span> /* fill out HPET address */</span><br><span> addr->space_id = 0; /* Memory */</span><br><span>diff --git a/src/soc/intel/fsp_broadwell_de/acpi.c b/src/soc/intel/fsp_broadwell_de/acpi.c</span><br><span>index 9b64edc..5d65477 100644</span><br><span>--- a/src/soc/intel/fsp_broadwell_de/acpi.c</span><br><span>+++ b/src/soc/intel/fsp_broadwell_de/acpi.c</span><br><span>@@ -125,7 +125,7 @@</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span> </span><br><span> header->length = sizeof(acpi_hpet_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(HPET);</span><br><span> </span><br><span> /* fill out HPET address */</span><br><span> addr->space_id = 0; /* Memory */</span><br><span>diff --git a/src/southbridge/intel/lynxpoint/acpi.c b/src/southbridge/intel/lynxpoint/acpi.c</span><br><span>index 2a02744..7f6a5ad 100644</span><br><span>--- a/src/southbridge/intel/lynxpoint/acpi.c</span><br><span>+++ b/src/southbridge/intel/lynxpoint/acpi.c</span><br><span>@@ -36,7 +36,7 @@</span><br><span> memcpy(header->asl_compiler_id, ASLC, 4);</span><br><span> </span><br><span> header->length = sizeof(acpi_hpet_t);</span><br><span style="color: hsl(0, 100%, 40%);">- header->revision = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ header->revision = get_acpi_table_revision(HPET);</span><br><span> </span><br><span> /* fill out HPET address */</span><br><span> addr->space_id = 0; /* Memory */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28278">change 28278</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28278"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Idb5e8ccd49ec27f87a290f33c62df3c177645669 </div>
<div style="display:none"> Gerrit-Change-Number: 28278 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marc Jones <marc@marcjonesconsulting.com> </div>