[coreboot-gerrit] Change in libgfxinit[master]: gma pipe_setup: Work around a PFIT_CONTROL quirk on G45

Arthur Heymans (Code Review) gerrit at coreboot.org
Tue Aug 21 18:39:37 CEST 2018


Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/28255


Change subject: gma pipe_setup: Work around a PFIT_CONTROL quirk on G45
......................................................................

gma pipe_setup: Work around a PFIT_CONTROL quirk on G45

In legacy VGA mode pillarbox fails to display anything, so just always force
'auto' mode, which will have the output stretched to fullscreen.

Change-Id: Ie7b7be06b5c5bd5569e8a6645dd9359660f7a51a
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M common/hw-gfx-gma-pipe_setup.adb
1 file changed, 8 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/55/28255/1

diff --git a/common/hw-gfx-gma-pipe_setup.adb b/common/hw-gfx-gma-pipe_setup.adb
index a45dfb2..cf35379 100644
--- a/common/hw-gfx-gma-pipe_setup.adb
+++ b/common/hw-gfx-gma-pipe_setup.adb
@@ -543,8 +543,15 @@
                when Secondary => GMCH_PFIT_CONTROL_SELECT_PIPE_B,
                when others    => 0);
 
+      -- Work around a quirk:
+      -- In legacy VGA mode Pillarbox fails to display anything so just force
+      -- 'auto' mode on all displays, which will the output stretched to
+      -- fullscreen .
       PF_Ctrl_Scaling : constant Word32 :=
-         GMCH_PFIT_CONTROL_SCALING (Scaling_Type (Framebuffer, Mode));
+        (if Framebuffer.Offset = VGA_PLANE_FRAMEBUFFER_OFFSET then
+           GMCH_PFIT_CONTROL_SCALING (Uniform)
+         else
+           GMCH_PFIT_CONTROL_SCALING (Scaling_Type (Framebuffer, Mode)));
 
       In_Use : Boolean;
    begin

-- 
To view, visit https://review.coreboot.org/28255
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7b7be06b5c5bd5569e8a6645dd9359660f7a51a
Gerrit-Change-Number: 28255
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180821/a27e8d58/attachment.html>


More information about the coreboot-gerrit mailing list