<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28255">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gma pipe_setup: Work around a PFIT_CONTROL quirk on G45<br><br>In legacy VGA mode pillarbox fails to display anything, so just always force<br>'auto' mode, which will have the output stretched to fullscreen.<br><br>Change-Id: Ie7b7be06b5c5bd5569e8a6645dd9359660f7a51a<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M common/hw-gfx-gma-pipe_setup.adb<br>1 file changed, 8 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/55/28255/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/common/hw-gfx-gma-pipe_setup.adb b/common/hw-gfx-gma-pipe_setup.adb</span><br><span>index a45dfb2..cf35379 100644</span><br><span>--- a/common/hw-gfx-gma-pipe_setup.adb</span><br><span>+++ b/common/hw-gfx-gma-pipe_setup.adb</span><br><span>@@ -543,8 +543,15 @@</span><br><span>                when Secondary => GMCH_PFIT_CONTROL_SELECT_PIPE_B,</span><br><span>                when others    => 0);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      -- Work around a quirk:</span><br><span style="color: hsl(120, 100%, 40%);">+      -- In legacy VGA mode Pillarbox fails to display anything so just force</span><br><span style="color: hsl(120, 100%, 40%);">+      -- 'auto' mode on all displays, which will the output stretched to</span><br><span style="color: hsl(120, 100%, 40%);">+      -- fullscreen .</span><br><span>       PF_Ctrl_Scaling : constant Word32 :=</span><br><span style="color: hsl(0, 100%, 40%);">-         GMCH_PFIT_CONTROL_SCALING (Scaling_Type (Framebuffer, Mode));</span><br><span style="color: hsl(120, 100%, 40%);">+        (if Framebuffer.Offset = VGA_PLANE_FRAMEBUFFER_OFFSET then</span><br><span style="color: hsl(120, 100%, 40%);">+           GMCH_PFIT_CONTROL_SCALING (Uniform)</span><br><span style="color: hsl(120, 100%, 40%);">+         else</span><br><span style="color: hsl(120, 100%, 40%);">+           GMCH_PFIT_CONTROL_SCALING (Scaling_Type (Framebuffer, Mode)));</span><br><span> </span><br><span>       In_Use : Boolean;</span><br><span>    begin</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28255">change 28255</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28255"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libgfxinit </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ie7b7be06b5c5bd5569e8a6645dd9359660f7a51a </div>
<div style="display:none"> Gerrit-Change-Number: 28255 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>