[coreboot-gerrit] Change in coreboot[master]: lib/gpio.c: Validate num_gpio

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue Aug 21 16:58:56 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28249 )

Change subject: lib/gpio.c: Validate num_gpio
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/28249/2/src/lib/gpio.c
File src/lib/gpio.c:

https://review.coreboot.org/#/c/28249/2/src/lib/gpio.c@85
PS2, Line 85: 	if((num_gpio <= 32) && (num_gpio > 0))
space required before the open parenthesis '('



-- 
To view, visit https://review.coreboot.org/28249
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b6537900fa41ebbee0171959f3ce236d360bc80
Gerrit-Change-Number: 28249
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 21 Aug 2018 14:58:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180821/5f8eb3ce/attachment.html>


More information about the coreboot-gerrit mailing list