[coreboot-gerrit] Change in coreboot[master]: google/kukui: Setup GPIOs for ChromeOS.

Tristan Hsieh (Code Review) gerrit at coreboot.org
Tue Aug 21 06:35:17 CEST 2018


Tristan Hsieh has uploaded this change for review. ( https://review.coreboot.org/28250


Change subject: google/kukui: Setup GPIOs for ChromeOS.
......................................................................

google/kukui: Setup GPIOs for ChromeOS.

Setup LID GPIO to boot depthchrage. Without this patch,
flag_fetch(FLAG_LIDSW) in depthcharge will fail

BUG=b:80501386
BRANCH=none
TEST=Boots correctly on Kukui

Change-Id: I0ec2c70c189a059219954e0384aaf98995285728
Signed-off-by: Tristan Shieh <tristan.shieh at mediatek.com>
---
M src/mainboard/google/kukui/Makefile.inc
M src/mainboard/google/kukui/bootblock.c
M src/mainboard/google/kukui/chromeos.c
A src/mainboard/google/kukui/gpio.h
4 files changed, 42 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/28250/1

diff --git a/src/mainboard/google/kukui/Makefile.inc b/src/mainboard/google/kukui/Makefile.inc
index 290be4c..aa6bf11 100644
--- a/src/mainboard/google/kukui/Makefile.inc
+++ b/src/mainboard/google/kukui/Makefile.inc
@@ -1,4 +1,5 @@
 bootblock-y += bootblock.c
+bootblock-y += chromeos.c
 bootblock-y += memlayout.ld
 decompressor-y += memlayout.ld
 
diff --git a/src/mainboard/google/kukui/bootblock.c b/src/mainboard/google/kukui/bootblock.c
index d8b5c5a..fa51488 100644
--- a/src/mainboard/google/kukui/bootblock.c
+++ b/src/mainboard/google/kukui/bootblock.c
@@ -18,10 +18,14 @@
 #include <soc/gpio.h>
 #include <soc/spi.h>
 
+#include "gpio.h"
+
 #define BOOTBLOCK_EN_L (GPIO(KPROW0))
 
 void bootblock_mainboard_init(void)
 {
+	setup_chromeos_gpios();
+
 	/* Turn on real eMMC. */
 	gpio_output(BOOTBLOCK_EN_L, 1);
 
diff --git a/src/mainboard/google/kukui/chromeos.c b/src/mainboard/google/kukui/chromeos.c
index 7f9946a..3ed5c1c 100644
--- a/src/mainboard/google/kukui/chromeos.c
+++ b/src/mainboard/google/kukui/chromeos.c
@@ -15,9 +15,21 @@
 
 #include <bootmode.h>
 #include <boot/coreboot_tables.h>
+#include <gpio.h>
+
+#include "gpio.h"
+
+void setup_chromeos_gpios(void)
+{
+	gpio_input(LID);
+}
 
 void fill_lb_gpios(struct lb_gpios *gpios)
 {
+	struct lb_gpio chromeos_gpios[] = {
+		{LID.id, ACTIVE_HIGH, -1, "lid"},
+	};
+	lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios));
 }
 
 int get_recovery_mode_switch(void)
diff --git a/src/mainboard/google/kukui/gpio.h b/src/mainboard/google/kukui/gpio.h
new file mode 100644
index 0000000..44610f4
--- /dev/null
+++ b/src/mainboard/google/kukui/gpio.h
@@ -0,0 +1,25 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2018 MediaTek Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __MAINBOARD_GOOGLE_KUKUI_GPIO_H__
+#define __MAINBOARD_GOOGLE_KUKUI_GPIO_H__
+
+#include <soc/gpio.h>
+
+#define LID GPIO(CAM_CLK2)
+
+void setup_chromeos_gpios(void);
+
+#endif

-- 
To view, visit https://review.coreboot.org/28250
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ec2c70c189a059219954e0384aaf98995285728
Gerrit-Change-Number: 28250
Gerrit-PatchSet: 1
Gerrit-Owner: Tristan Hsieh <tristan.shieh at mediatek.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180821/644d2ed3/attachment.html>


More information about the coreboot-gerrit mailing list