[coreboot-gerrit] Change in coreboot[master]: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs

[Enrico Granata (Code Review)]

Enrico Granata has posted comments on this change. ( https://review.coreboot.org/28112 )

Change subject: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs
......................................................................


Patch Set 1:

(2 comments)

Two lines of patch & two comments. Good ratio there :-)

https://review.coreboot.org/#/c/28112/1/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
File src/mainboard/google/poppy/variants/nocturne/devicetree.cb:

https://review.coreboot.org/#/c/28112/1/src/mainboard/google/poppy/variants/nocturne/devicetree.cb@312
PS1, Line 312: 				register "reg_prox_ctrl10" = "0x1F"
> nit: 1f
Done


https://review.coreboot.org/#/c/28112/1/src/mainboard/google/poppy/variants/nocturne/devicetree.cb@353
PS1, Line 353: 				register "reg_prox_ctrl10" = "0x1F"
> nit: 1f
Done



-- 
To view, visit https://review.coreboot.org/28112
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571
Gerrit-Change-Number: 28112
Gerrit-PatchSet: 1
Gerrit-Owner: Enrico Granata <egranata at chromium.org>
Gerrit-Reviewer: Enrico Granata <egranata at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Gwendal Grignou <gwendal at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 16 Aug 2018 23:44:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180816/7a6e6b30/attachment.html>