[coreboot-gerrit] Change in coreboot[master]: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs

Enrico Granata (Code Review) gerrit at coreboot.org
Fri Aug 17 01:44:23 CEST 2018


Hello Gwendal Grignou, build bot (Jenkins), Furquan Shaikh, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/28112

to look at the new patch set (#2).

Change subject: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs
......................................................................

nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs

This is meant to solve an issue where the proximity sensor may fluctuate
between CLOSE / FAR in rapid succession upon the user removing their hand
from the unit, before settling on the correct output.

Using the hardware debouncing filter solves this issue and removes the
spurious fluctuations.

BRANCH=None
BUG=None
TEST=manual on Nocturne, observing events come in

Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571
Signed-off-by: Enrico Granata <egranata at chromium.org>
---
M src/mainboard/google/poppy/variants/nocturne/devicetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/28112/2
-- 
To view, visit https://review.coreboot.org/28112
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571
Gerrit-Change-Number: 28112
Gerrit-PatchSet: 2
Gerrit-Owner: Enrico Granata <egranata at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Gwendal Grignou <gwendal at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180816/480e8f8f/attachment.html>


More information about the coreboot-gerrit mailing list