[coreboot-gerrit] Change in coreboot[master]: libpayload/x86/exception: Add ability to handle user defined interrupts

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/28100 )

Change subject: libpayload/x86/exception: Add ability to handle user defined interrupts
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/28100/1/payloads/libpayload/arch/x86/exception.c
File payloads/libpayload/arch/x86/exception.c:

https://review.coreboot.org/#/c/28100/1/payloads/libpayload/arch/x86/exception.c@165
PS1, Line 165: 	/* Handle user defined vectors */
> Ah, I haven't tested with a gdb build yet, so I haven't seen it break. […]
If you think that's better, sure. I doubt we'll ever have enough handlers for the list to really be a problem, but it doesn't make a big difference either way (you're trading the time to iterate through a tiny list vs. the time to initialize a 2K array of function pointers).



-- 
To view, visit https://review.coreboot.org/28100
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c2583c7c3d9be4a06a25e546e64399f2b0620c
Gerrit-Change-Number: 28100
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Julius Werner <jwerner at chromium.org>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Thu, 16 Aug 2018 20:45:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180816/1b694969/attachment.html>