<p><a href="https://review.coreboot.org/28100">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28100/1/payloads/libpayload/arch/x86/exception.c">File payloads/libpayload/arch/x86/exception.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28100/1/payloads/libpayload/arch/x86/exception.c@165">Patch Set #1, Line 165:</a> <code style="font-family:monospace,monospace">        /* Handle user defined vectors */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Ah, I haven't tested with a gdb build yet, so I haven't seen it break. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">If you think that's better, sure. I doubt we'll ever have enough handlers for the list to really be a problem, but it doesn't make a big difference either way (you're trading the time to iterate through a tiny list vs. the time to initialize a 2K array of function pointers).</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28100">change 28100</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28100"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id9c2583c7c3d9be4a06a25e546e64399f2b0620c </div>
<div style="display:none"> Gerrit-Change-Number: 28100 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Raul Rangel <rrangel@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-CC: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 16 Aug 2018 20:45:00 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>