[coreboot-gerrit] Change in coreboot[master]: lib/fit_payload: Add coreboot tables support for FDT.

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28104 )

Change subject: lib/fit_payload: Add coreboot tables support for FDT.
......................................................................


Patch Set 7: Code-Review+1

(3 comments)

https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c
File src/lib/fit_payload.c:

https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c@103
PS7, Line 103: tables
And strappings


https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c@153
PS7, Line 153: userspace
Why userspace ? I'd use the term payload here


https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c@202
PS7, Line 202: add_cb_fdt_data(dt)
Should be after dt_apply_fixups(), as it could remove and regenerate the whole devicetree.



-- 
To view, visit https://review.coreboot.org/28104
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977
Gerrit-Change-Number: 28104
Gerrit-PatchSet: 7
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Julius Werner <jwerner at chromium.org>
Gerrit-Comment-Date: Thu, 16 Aug 2018 08:17:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180816/3836c5cb/attachment.html>