<p>Patch set 7:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://review.coreboot.org/28104">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c">File src/lib/fit_payload.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c@103">Patch Set #7, Line 103:</a> <code style="font-family:monospace,monospace">tables</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">And strappings</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c@153">Patch Set #7, Line 153:</a> <code style="font-family:monospace,monospace">userspace</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why userspace ? I'd use the term payload here</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c@202">Patch Set #7, Line 202:</a> <code style="font-family:monospace,monospace">add_cb_fdt_data(dt)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should be after dt_apply_fixups(), as it could remove and regenerate the whole devicetree.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28104">change 28104</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28104"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib714a021a24f51407558f484cd97aa58ecd43977 </div>
<div style="display:none"> Gerrit-Change-Number: 28104 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 16 Aug 2018 08:17:33 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>