[coreboot-gerrit] Change in coreboot[master]: mainboard/google/nocturne: turn off cams in D3

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/28073 )

Change subject: mainboard/google/nocturne: turn off cams in D3
......................................................................


Patch Set 1:

Can't find some proper documentation described that more clearly. Other than ACPI spec itself, https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/device-power-management may also have some high level descriptions.

Okay, so go back to the real problem itself. Without _PR3, nocturne can still enter s0ix state properly with same level of power consumption? On my side, all the reference platform with MIPI camera support all have _PR3 there, in early stage people still use _PS0 and _PS3 to put the code directly, but later all switch to _PR0 and _PR3 with _ON and _OFF inside power resources.  For the privacy LED always on issue, what about move some the turn off programming to _STA that will be loaded as first input of driver? Or maybe move the programing to pre-OS stage to coreboot? Using windbg to log ACPI event through AMLI debugger may be easier to understand the sequence I believe.


-- 
To view, visit https://review.coreboot.org/28073
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id52c2499c3b7577f03395cc9ca2460f25b80e13f
Gerrit-Change-Number: 28073
Gerrit-PatchSet: 1
Gerrit-Owner: Matt Delco <delco at chromium.org>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Matt Delco <delco at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Lance Zhao <lance.zhao at gmail.com>
Gerrit-Comment-Date: Thu, 16 Aug 2018 06:18:16 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180816/a7b16ecd/attachment.html>