[coreboot-gerrit] Change in coreboot[master]: mainboard/google/nocturne: turn off cams in D3

[Matt Delco (Code Review)]

Matt Delco has posted comments on this change. ( https://review.coreboot.org/28073 )

Change subject: mainboard/google/nocturne: turn off cams in D3
......................................................................


Patch Set 1:

> Again I don't think that statement is true, a value in _PR3 does not mean to 
> keep device power in D3Hot. For your reference, the following code 
> https://chromium.googlesource.com/chromiumos/third_party/kernel/+/stabilize-nocturne.10646.B-chromeos-4.14/drivers/acpi/power.c did explain that.

Is there a particular place that is supposed to illustrate this?  It looks to me like acpi_power_transition() calls acpi_power_on_list() on items in the list for the new power state and calls acpi_power_off_list() on items in old list.  So, having a _PR3 keeps the power on in D3Hot.

> May I know what kind of problem you are facing now?
> The steps in _OFF had not been executed?

The device (or at least the privacy light) never turns off in Windows.  If no driver is installed for the camera then the light stays on.  If I install a driver for the device then the light stays on.  If I install a driver and modify ACPI then the light does turn off.  I might be able to convince the light to go off by having the driver try harder to claim support for D3cold but this is going beyond the Intel reference examples and again I don't see any other MIPI camera outside of coreboot that uses _PR3.


-- 
To view, visit https://review.coreboot.org/28073
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id52c2499c3b7577f03395cc9ca2460f25b80e13f
Gerrit-Change-Number: 28073
Gerrit-PatchSet: 1
Gerrit-Owner: Matt Delco <delco at chromium.org>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Matt Delco <delco at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Lance Zhao <lance.zhao at gmail.com>
Gerrit-Comment-Date: Tue, 14 Aug 2018 20:43:31 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180814/fb2a2596/attachment.html>