[coreboot-gerrit] Change in coreboot[master]: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs

Enrico Granata (Code Review) gerrit at coreboot.org
Thu Aug 16 02:14:18 CEST 2018


Enrico Granata has uploaded this change for review. ( https://review.coreboot.org/28112


Change subject: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs
......................................................................

nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs

This is meant to solve an issue where the proximity sensor may fluctuate
between CLOSE / FAR in rapid succession upon the user removing their hand
from the unit, before settling on the correct output.

Using the hardware debouncing filter solves this issue and removes the
spurious fluctuations.

BRANCH=None
BUG=None
TEST=manual on Nocturne, observing events come in

Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571
Signed-off-by: Enrico Granata <egranata at chromium.org>
---
M src/mainboard/google/poppy/variants/nocturne/devicetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/28112/1

diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
index 88af929..32f09f1 100644
--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
@@ -309,7 +309,7 @@
 				register "reg_prox_ctrl7" = "0x0d"
 				register "reg_prox_ctrl8" = "0x8d"
 				register "reg_prox_ctrl9" = "0x43"
-				register "reg_prox_ctrl10" = "0x11"
+				register "reg_prox_ctrl10" = "0x1F"
 				register "reg_prox_ctrl11" = "0x00"
 				register "reg_prox_ctrl12" = "0x00"
 				register "reg_prox_ctrl13" = "0x00"
@@ -350,7 +350,7 @@
 				register "reg_prox_ctrl7" = "0x0d"
 				register "reg_prox_ctrl8" = "0x8d"
 				register "reg_prox_ctrl9" = "0x43"
-				register "reg_prox_ctrl10" = "0x11"
+				register "reg_prox_ctrl10" = "0x1F"
 				register "reg_prox_ctrl11" = "0x00"
 				register "reg_prox_ctrl12" = "0x00"
 				register "reg_prox_ctrl13" = "0x00"

-- 
To view, visit https://review.coreboot.org/28112
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571
Gerrit-Change-Number: 28112
Gerrit-PatchSet: 1
Gerrit-Owner: Enrico Granata <egranata at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180816/ae8a9b4b/attachment.html>


More information about the coreboot-gerrit mailing list