<p>Enrico Granata has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28112">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs<br><br>This is meant to solve an issue where the proximity sensor may fluctuate<br>between CLOSE / FAR in rapid succession upon the user removing their hand<br>from the unit, before settling on the correct output.<br><br>Using the hardware debouncing filter solves this issue and removes the<br>spurious fluctuations.<br><br>BRANCH=None<br>BUG=None<br>TEST=manual on Nocturne, observing events come in<br><br>Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571<br>Signed-off-by: Enrico Granata <egranata@chromium.org><br>---<br>M src/mainboard/google/poppy/variants/nocturne/devicetree.cb<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/28112/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>index 88af929..32f09f1 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>@@ -309,7 +309,7 @@</span><br><span>                                register "reg_prox_ctrl7" = "0x0d"</span><br><span>                               register "reg_prox_ctrl8" = "0x8d"</span><br><span>                               register "reg_prox_ctrl9" = "0x43"</span><br><span style="color: hsl(0, 100%, 40%);">-                          register "reg_prox_ctrl10" = "0x11"</span><br><span style="color: hsl(120, 100%, 40%);">+                               register "reg_prox_ctrl10" = "0x1F"</span><br><span>                              register "reg_prox_ctrl11" = "0x00"</span><br><span>                              register "reg_prox_ctrl12" = "0x00"</span><br><span>                              register "reg_prox_ctrl13" = "0x00"</span><br><span>@@ -350,7 +350,7 @@</span><br><span>                                register "reg_prox_ctrl7" = "0x0d"</span><br><span>                               register "reg_prox_ctrl8" = "0x8d"</span><br><span>                               register "reg_prox_ctrl9" = "0x43"</span><br><span style="color: hsl(0, 100%, 40%);">-                          register "reg_prox_ctrl10" = "0x11"</span><br><span style="color: hsl(120, 100%, 40%);">+                               register "reg_prox_ctrl10" = "0x1F"</span><br><span>                              register "reg_prox_ctrl11" = "0x00"</span><br><span>                              register "reg_prox_ctrl12" = "0x00"</span><br><span>                              register "reg_prox_ctrl13" = "0x00"</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28112">change 28112</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28112"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571 </div>
<div style="display:none"> Gerrit-Change-Number: 28112 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Enrico Granata <egranata@chromium.org> </div>