[coreboot-gerrit] Change in coreboot[master]: mainboard/google: delete tablet mode defines
Matt Delco (Code Review)
gerrit at coreboot.org
Thu Aug 16 00:59:34 CEST 2018
Matt Delco has uploaded this change for review. ( https://review.coreboot.org/28109
Change subject: mainboard/google: delete tablet mode defines
......................................................................
mainboard/google: delete tablet mode defines
The define for the tablet mode device has changed to Kconfig, so the
instances of enabling the device via ec.h can now be removed.
Change-Id: I3e0e20df6698180e34fc281cf691cad228486953
Signed-off-by: Matt Delco <delco at chromium.org>
---
M src/mainboard/google/eve/ec.h
M src/mainboard/google/octopus/variants/phaser/include/variant/ec.h
M src/mainboard/google/octopus/variants/yorp/include/variant/ec.h
M src/mainboard/google/poppy/variants/nami/include/variant/ec.h
M src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h
M src/mainboard/google/poppy/variants/rammus/include/variant/ec.h
M src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
7 files changed, 0 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/28109/1
diff --git a/src/mainboard/google/eve/ec.h b/src/mainboard/google/eve/ec.h
index 1b55248..81d591c 100644
--- a/src/mainboard/google/eve/ec.h
+++ b/src/mainboard/google/eve/ec.h
@@ -79,8 +79,6 @@
/* Enable Tablet switch */
#define EC_ENABLE_TABLET_EVENT
-#define EC_ENABLE_TBMC_DEVICE
-
#define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */
#define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */
#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */
diff --git a/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h b/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h
index 48cb584..16f931b 100644
--- a/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h
+++ b/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h
@@ -18,7 +18,4 @@
#include <baseboard/ec.h>
-/* Enable Tablet switch */
-#define EC_ENABLE_TBMC_DEVICE
-
#endif
diff --git a/src/mainboard/google/octopus/variants/yorp/include/variant/ec.h b/src/mainboard/google/octopus/variants/yorp/include/variant/ec.h
index 48cb584..16f931b 100644
--- a/src/mainboard/google/octopus/variants/yorp/include/variant/ec.h
+++ b/src/mainboard/google/octopus/variants/yorp/include/variant/ec.h
@@ -18,7 +18,4 @@
#include <baseboard/ec.h>
-/* Enable Tablet switch */
-#define EC_ENABLE_TBMC_DEVICE
-
#endif
diff --git a/src/mainboard/google/poppy/variants/nami/include/variant/ec.h b/src/mainboard/google/poppy/variants/nami/include/variant/ec.h
index a5a0196..52a24e5 100644
--- a/src/mainboard/google/poppy/variants/nami/include/variant/ec.h
+++ b/src/mainboard/google/poppy/variants/nami/include/variant/ec.h
@@ -70,7 +70,6 @@
/* Enable Tablet switch */
#define EC_ENABLE_TABLET_EVENT
-#define EC_ENABLE_TBMC_DEVICE
#define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */
#define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */
diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h b/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h
index 70f12d5..ca9f865 100644
--- a/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h
+++ b/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h
@@ -72,7 +72,6 @@
#define EC_ENABLE_LID_SWITCH
#define EC_ENABLE_WAKE_PIN GPE_EC_WAKE
#define EC_ENABLE_TABLET_EVENT
-#define EC_ENABLE_TBMC_DEVICE
#define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */
#define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */
diff --git a/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h b/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h
index b22fccb..302eb42 100644
--- a/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h
+++ b/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h
@@ -74,7 +74,6 @@
/* Enable Tablet switch */
#define EC_ENABLE_TABLET_EVENT
-#define EC_ENABLE_TBMC_DEVICE
#define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */
#define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */
diff --git a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
index 6e1de7a..6e5b277 100644
--- a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
+++ b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
@@ -71,8 +71,6 @@
#define EC_ENABLE_LID_SWITCH
#define EC_ENABLE_WAKE_PIN GPE_EC_WAKE
-#define EC_ENABLE_TBMC_DEVICE
-
#define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */
#define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */
#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */
--
To view, visit https://review.coreboot.org/28109
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e0e20df6698180e34fc281cf691cad228486953
Gerrit-Change-Number: 28109
Gerrit-PatchSet: 1
Gerrit-Owner: Matt Delco <delco at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180815/7114b8d9/attachment-0001.html>
More information about the coreboot-gerrit
mailing list