<p>Matt Delco has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28109">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google: delete tablet mode defines<br><br>The define for the tablet mode device has changed to Kconfig, so the<br>instances of enabling the device via ec.h can now be removed.<br><br>Change-Id: I3e0e20df6698180e34fc281cf691cad228486953<br>Signed-off-by: Matt Delco <delco@chromium.org><br>---<br>M src/mainboard/google/eve/ec.h<br>M src/mainboard/google/octopus/variants/phaser/include/variant/ec.h<br>M src/mainboard/google/octopus/variants/yorp/include/variant/ec.h<br>M src/mainboard/google/poppy/variants/nami/include/variant/ec.h<br>M src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h<br>M src/mainboard/google/poppy/variants/rammus/include/variant/ec.h<br>M src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h<br>7 files changed, 0 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/28109/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/eve/ec.h b/src/mainboard/google/eve/ec.h</span><br><span>index 1b55248..81d591c 100644</span><br><span>--- a/src/mainboard/google/eve/ec.h</span><br><span>+++ b/src/mainboard/google/eve/ec.h</span><br><span>@@ -79,8 +79,6 @@</span><br><span> /* Enable Tablet switch */</span><br><span> #define EC_ENABLE_TABLET_EVENT</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define EC_ENABLE_TBMC_DEVICE</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> #define SIO_EC_MEMMAP_ENABLE     /* EC Memory Map Resources */</span><br><span> #define SIO_EC_HOST_ENABLE     /* EC Host Interface Resources */</span><br><span> #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */</span><br><span>diff --git a/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h b/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h</span><br><span>index 48cb584..16f931b 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h</span><br><span>+++ b/src/mainboard/google/octopus/variants/phaser/include/variant/ec.h</span><br><span>@@ -18,7 +18,4 @@</span><br><span> </span><br><span> #include <baseboard/ec.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Enable Tablet switch */</span><br><span style="color: hsl(0, 100%, 40%);">-#define EC_ENABLE_TBMC_DEVICE</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> #endif</span><br><span>diff --git a/src/mainboard/google/octopus/variants/yorp/include/variant/ec.h b/src/mainboard/google/octopus/variants/yorp/include/variant/ec.h</span><br><span>index 48cb584..16f931b 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/yorp/include/variant/ec.h</span><br><span>+++ b/src/mainboard/google/octopus/variants/yorp/include/variant/ec.h</span><br><span>@@ -18,7 +18,4 @@</span><br><span> </span><br><span> #include <baseboard/ec.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Enable Tablet switch */</span><br><span style="color: hsl(0, 100%, 40%);">-#define EC_ENABLE_TBMC_DEVICE</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> #endif</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nami/include/variant/ec.h b/src/mainboard/google/poppy/variants/nami/include/variant/ec.h</span><br><span>index a5a0196..52a24e5 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nami/include/variant/ec.h</span><br><span>+++ b/src/mainboard/google/poppy/variants/nami/include/variant/ec.h</span><br><span>@@ -70,7 +70,6 @@</span><br><span> </span><br><span> /* Enable Tablet switch */</span><br><span> #define EC_ENABLE_TABLET_EVENT</span><br><span style="color: hsl(0, 100%, 40%);">-#define EC_ENABLE_TBMC_DEVICE</span><br><span> </span><br><span> #define SIO_EC_MEMMAP_ENABLE  /* EC Memory Map Resources */</span><br><span> #define SIO_EC_HOST_ENABLE     /* EC Host Interface Resources */</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h b/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h</span><br><span>index 70f12d5..ca9f865 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h</span><br><span>+++ b/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h</span><br><span>@@ -72,7 +72,6 @@</span><br><span> #define EC_ENABLE_LID_SWITCH</span><br><span> #define EC_ENABLE_WAKE_PIN    GPE_EC_WAKE</span><br><span> #define EC_ENABLE_TABLET_EVENT</span><br><span style="color: hsl(0, 100%, 40%);">-#define EC_ENABLE_TBMC_DEVICE</span><br><span> </span><br><span> #define SIO_EC_MEMMAP_ENABLE  /* EC Memory Map Resources */</span><br><span> #define SIO_EC_HOST_ENABLE     /* EC Host Interface Resources */</span><br><span>diff --git a/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h b/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h</span><br><span>index b22fccb..302eb42 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h</span><br><span>+++ b/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h</span><br><span>@@ -74,7 +74,6 @@</span><br><span> </span><br><span> /* Enable Tablet switch */</span><br><span> #define EC_ENABLE_TABLET_EVENT</span><br><span style="color: hsl(0, 100%, 40%);">-#define EC_ENABLE_TBMC_DEVICE</span><br><span> </span><br><span> #define SIO_EC_MEMMAP_ENABLE     /* EC Memory Map Resources */</span><br><span> #define SIO_EC_HOST_ENABLE     /* EC Host Interface Resources */</span><br><span>diff --git a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h</span><br><span>index 6e1de7a..6e5b277 100644</span><br><span>--- a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h</span><br><span>+++ b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h</span><br><span>@@ -71,8 +71,6 @@</span><br><span> #define EC_ENABLE_LID_SWITCH</span><br><span> #define EC_ENABLE_WAKE_PIN    GPE_EC_WAKE</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define EC_ENABLE_TBMC_DEVICE</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> #define SIO_EC_MEMMAP_ENABLE     /* EC Memory Map Resources */</span><br><span> #define SIO_EC_HOST_ENABLE       /* EC Host Interface Resources */</span><br><span> #define SIO_EC_ENABLE_PS2K       /* Enable PS/2 Keyboard */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28109">change 28109</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28109"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3e0e20df6698180e34fc281cf691cad228486953 </div>
<div style="display:none"> Gerrit-Change-Number: 28109 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt Delco <delco@chromium.org> </div>