[coreboot-gerrit] Change in coreboot[master]: vendorcode/amd/pi/00670F00/binaryPI/AGESA.c: Remove VENDORCODE_FULL_S...

Richard Spiegel (Code Review) gerrit at coreboot.org
Tue Aug 14 23:06:25 CEST 2018


Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/28090


Change subject: vendorcode/amd/pi/00670F00/binaryPI/AGESA.c: Remove VENDORCODE_FULL_SUPPORT
......................................................................

vendorcode/amd/pi/00670F00/binaryPI/AGESA.c: Remove VENDORCODE_FULL_SUPPORT

Remove VENDORCODE_FULL_SUPPORT from file above mentioned file, in
preparation to full removal of VENDORCODE_FULL_SUPPORT functions.

BUG=b:112578491
TEST=none, VENDORCODE_FULL_SUPPORT already not used.

Change-Id: Id91e76282509743070e34c02082d3f3f46a14059
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
1 file changed, 0 insertions(+), 99 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/28090/1

diff --git a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
index ea55343..c42df59 100644
--- a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
@@ -157,22 +157,6 @@
 	return Dispatcher(LateParams);
 }
 
-#if IS_ENABLED(CONFIG_VENDORCODE_FULL_SUPPORT)
-/**********************************************************************
- * Interface call:  AmdInitRecovery
- **********************************************************************/
-AGESA_STATUS
-AmdInitRecovery (
-  IN OUT   AMD_RECOVERY_PARAMS    *RecoveryParams
-  )
-{
-	MODULE_ENTRY Dispatcher = agesa_get_dispatcher();
-	RecoveryParams->StdHeader.Func = AMD_INIT_RECOVERY;
-	if (!Dispatcher) return AGESA_UNSUPPORTED;
-	return Dispatcher(RecoveryParams);
-}
-#endif /* IS_ENABLED(CONFIG_VENDORCODE_FULL_SUPPORT) */
-
 /**********************************************************************
  * Interface call:  AmdInitResume
  **********************************************************************/
@@ -243,50 +227,6 @@
 	return Dispatcher(AmdApExeParams);
 }
 
-#if IS_ENABLED(CONFIG_VENDORCODE_FULL_SUPPORT)
-/**********************************************************************
- * Interface service call:  AmdGetApicId
- **********************************************************************/
-AGESA_STATUS
-AmdGetApicId (
-  IN OUT AMD_APIC_PARAMS *AmdParamApic
-)
-{
-	MODULE_ENTRY Dispatcher = agesa_get_dispatcher();
-	AmdParamApic->StdHeader.Func = AMD_GET_APIC_ID;
-	if (!Dispatcher) return AGESA_UNSUPPORTED;
-	return Dispatcher(AmdParamApic);
-}
-
-/**********************************************************************
- * Interface service call:  AmdGetPciAddress
- **********************************************************************/
-AGESA_STATUS
-AmdGetPciAddress (
-  IN OUT   AMD_GET_PCI_PARAMS *AmdParamGetPci
-)
-{
-	MODULE_ENTRY Dispatcher = agesa_get_dispatcher();
-	AmdParamGetPci->StdHeader.Func = AMD_GET_PCI_ADDRESS;
-	if (!Dispatcher) return AGESA_UNSUPPORTED;
-	return Dispatcher(AmdParamGetPci);
-}
-
-/**********************************************************************
- * Interface service call:  AmdIdentifyCore
- **********************************************************************/
-AGESA_STATUS
-AmdIdentifyCore (
-  IN OUT  AMD_IDENTIFY_PARAMS *AmdParamIdentify
-)
-{
-	MODULE_ENTRY Dispatcher = agesa_get_dispatcher();
-	AmdParamIdentify->StdHeader.Func = AMD_IDENTIFY_CORE;
-	if (!Dispatcher) return AGESA_UNSUPPORTED;
-	return Dispatcher(AmdParamIdentify);
-}
-#endif /* IS_ENABLED(CONFIG_VENDORCODE_FULL_SUPPORT) */
-
 /**********************************************************************
  * Interface service call:  AmdReadEventLog
  **********************************************************************/
@@ -300,42 +240,3 @@
 	if (!Dispatcher) return AGESA_UNSUPPORTED;
 	return Dispatcher(Event);
 }
-
-#if IS_ENABLED(CONFIG_VENDORCODE_FULL_SUPPORT)
-/**********************************************************************
- * Interface service call:  AmdIdentifyDimm
- **********************************************************************/
-AGESA_STATUS
-AmdIdentifyDimm (
-  IN OUT   AMD_IDENTIFY_DIMM *AmdDimmIdentify
-)
-{
-	MODULE_ENTRY Dispatcher = agesa_get_dispatcher();
-	AmdDimmIdentify->StdHeader.Func = AMD_IDENTIFY_DIMMS;
-	if (!Dispatcher) return AGESA_UNSUPPORTED;
-	return Dispatcher(AmdDimmIdentify);
-}
-
-AGESA_STATUS
-AmdIdsRunApTaskLate (
-  IN       AP_EXE_PARAMS  *AmdApExeParams
-  )
-{
-	AmdApExeParams->StdHeader.Func = -1;
-	return AGESA_UNSUPPORTED;
-}
-
-/**********************************************************************
- * Interface service call:  AmdGet2DDataEye
- **********************************************************************/
-AGESA_STATUS
-AmdGet2DDataEye (
-  IN OUT   AMD_GET_DATAEYE *AmdGetDataEye
-  )
-{
-	MODULE_ENTRY Dispatcher = agesa_get_dispatcher();
-	AmdGetDataEye->StdHeader.Func = AMD_GET_2D_DATA_EYE;
-	if (!Dispatcher) return AGESA_UNSUPPORTED;
-	return Dispatcher(AmdGetDataEye);
-}
-#endif /* IS_ENABLED(CONFIG_VENDORCODE_FULL_SUPPORT) */

-- 
To view, visit https://review.coreboot.org/28090
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id91e76282509743070e34c02082d3f3f46a14059
Gerrit-Change-Number: 28090
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180814/6a57b537/attachment.html>


More information about the coreboot-gerrit mailing list