<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28090">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vendorcode/amd/pi/00670F00/binaryPI/AGESA.c: Remove VENDORCODE_FULL_SUPPORT<br><br>Remove VENDORCODE_FULL_SUPPORT from file above mentioned file, in<br>preparation to full removal of VENDORCODE_FULL_SUPPORT functions.<br><br>BUG=b:112578491<br>TEST=none, VENDORCODE_FULL_SUPPORT already not used.<br><br>Change-Id: Id91e76282509743070e34c02082d3f3f46a14059<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c<br>1 file changed, 0 insertions(+), 99 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/28090/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c</span><br><span>index ea55343..c42df59 100644</span><br><span>--- a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c</span><br><span>+++ b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c</span><br><span>@@ -157,22 +157,6 @@</span><br><span> return Dispatcher(LateParams);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#if IS_ENABLED(CONFIG_VENDORCODE_FULL_SUPPORT)</span><br><span style="color: hsl(0, 100%, 40%);">-/**********************************************************************</span><br><span style="color: hsl(0, 100%, 40%);">- * Interface call: AmdInitRecovery</span><br><span style="color: hsl(0, 100%, 40%);">- **********************************************************************/</span><br><span style="color: hsl(0, 100%, 40%);">-AGESA_STATUS</span><br><span style="color: hsl(0, 100%, 40%);">-AmdInitRecovery (</span><br><span style="color: hsl(0, 100%, 40%);">- IN OUT AMD_RECOVERY_PARAMS *RecoveryParams</span><br><span style="color: hsl(0, 100%, 40%);">- )</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- MODULE_ENTRY Dispatcher = agesa_get_dispatcher();</span><br><span style="color: hsl(0, 100%, 40%);">- RecoveryParams->StdHeader.Func = AMD_INIT_RECOVERY;</span><br><span style="color: hsl(0, 100%, 40%);">- if (!Dispatcher) return AGESA_UNSUPPORTED;</span><br><span style="color: hsl(0, 100%, 40%);">- return Dispatcher(RecoveryParams);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-#endif /* IS_ENABLED(CONFIG_VENDORCODE_FULL_SUPPORT) */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /**********************************************************************</span><br><span> * Interface call: AmdInitResume</span><br><span> **********************************************************************/</span><br><span>@@ -243,50 +227,6 @@</span><br><span> return Dispatcher(AmdApExeParams);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#if IS_ENABLED(CONFIG_VENDORCODE_FULL_SUPPORT)</span><br><span style="color: hsl(0, 100%, 40%);">-/**********************************************************************</span><br><span style="color: hsl(0, 100%, 40%);">- * Interface service call: AmdGetApicId</span><br><span style="color: hsl(0, 100%, 40%);">- **********************************************************************/</span><br><span style="color: hsl(0, 100%, 40%);">-AGESA_STATUS</span><br><span style="color: hsl(0, 100%, 40%);">-AmdGetApicId (</span><br><span style="color: hsl(0, 100%, 40%);">- IN OUT AMD_APIC_PARAMS *AmdParamApic</span><br><span style="color: hsl(0, 100%, 40%);">-)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- MODULE_ENTRY Dispatcher = agesa_get_dispatcher();</span><br><span style="color: hsl(0, 100%, 40%);">- AmdParamApic->StdHeader.Func = AMD_GET_APIC_ID;</span><br><span style="color: hsl(0, 100%, 40%);">- if (!Dispatcher) return AGESA_UNSUPPORTED;</span><br><span style="color: hsl(0, 100%, 40%);">- return Dispatcher(AmdParamApic);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/**********************************************************************</span><br><span style="color: hsl(0, 100%, 40%);">- * Interface service call: AmdGetPciAddress</span><br><span style="color: hsl(0, 100%, 40%);">- **********************************************************************/</span><br><span style="color: hsl(0, 100%, 40%);">-AGESA_STATUS</span><br><span style="color: hsl(0, 100%, 40%);">-AmdGetPciAddress (</span><br><span style="color: hsl(0, 100%, 40%);">- IN OUT AMD_GET_PCI_PARAMS *AmdParamGetPci</span><br><span style="color: hsl(0, 100%, 40%);">-)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- MODULE_ENTRY Dispatcher = agesa_get_dispatcher();</span><br><span style="color: hsl(0, 100%, 40%);">- AmdParamGetPci->StdHeader.Func = AMD_GET_PCI_ADDRESS;</span><br><span style="color: hsl(0, 100%, 40%);">- if (!Dispatcher) return AGESA_UNSUPPORTED;</span><br><span style="color: hsl(0, 100%, 40%);">- return Dispatcher(AmdParamGetPci);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/**********************************************************************</span><br><span style="color: hsl(0, 100%, 40%);">- * Interface service call: AmdIdentifyCore</span><br><span style="color: hsl(0, 100%, 40%);">- **********************************************************************/</span><br><span style="color: hsl(0, 100%, 40%);">-AGESA_STATUS</span><br><span style="color: hsl(0, 100%, 40%);">-AmdIdentifyCore (</span><br><span style="color: hsl(0, 100%, 40%);">- IN OUT AMD_IDENTIFY_PARAMS *AmdParamIdentify</span><br><span style="color: hsl(0, 100%, 40%);">-)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- MODULE_ENTRY Dispatcher = agesa_get_dispatcher();</span><br><span style="color: hsl(0, 100%, 40%);">- AmdParamIdentify->StdHeader.Func = AMD_IDENTIFY_CORE;</span><br><span style="color: hsl(0, 100%, 40%);">- if (!Dispatcher) return AGESA_UNSUPPORTED;</span><br><span style="color: hsl(0, 100%, 40%);">- return Dispatcher(AmdParamIdentify);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-#endif /* IS_ENABLED(CONFIG_VENDORCODE_FULL_SUPPORT) */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /**********************************************************************</span><br><span> * Interface service call: AmdReadEventLog</span><br><span> **********************************************************************/</span><br><span>@@ -300,42 +240,3 @@</span><br><span> if (!Dispatcher) return AGESA_UNSUPPORTED;</span><br><span> return Dispatcher(Event);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#if IS_ENABLED(CONFIG_VENDORCODE_FULL_SUPPORT)</span><br><span style="color: hsl(0, 100%, 40%);">-/**********************************************************************</span><br><span style="color: hsl(0, 100%, 40%);">- * Interface service call: AmdIdentifyDimm</span><br><span style="color: hsl(0, 100%, 40%);">- **********************************************************************/</span><br><span style="color: hsl(0, 100%, 40%);">-AGESA_STATUS</span><br><span style="color: hsl(0, 100%, 40%);">-AmdIdentifyDimm (</span><br><span style="color: hsl(0, 100%, 40%);">- IN OUT AMD_IDENTIFY_DIMM *AmdDimmIdentify</span><br><span style="color: hsl(0, 100%, 40%);">-)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- MODULE_ENTRY Dispatcher = agesa_get_dispatcher();</span><br><span style="color: hsl(0, 100%, 40%);">- AmdDimmIdentify->StdHeader.Func = AMD_IDENTIFY_DIMMS;</span><br><span style="color: hsl(0, 100%, 40%);">- if (!Dispatcher) return AGESA_UNSUPPORTED;</span><br><span style="color: hsl(0, 100%, 40%);">- return Dispatcher(AmdDimmIdentify);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-AGESA_STATUS</span><br><span style="color: hsl(0, 100%, 40%);">-AmdIdsRunApTaskLate (</span><br><span style="color: hsl(0, 100%, 40%);">- IN AP_EXE_PARAMS *AmdApExeParams</span><br><span style="color: hsl(0, 100%, 40%);">- )</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- AmdApExeParams->StdHeader.Func = -1;</span><br><span style="color: hsl(0, 100%, 40%);">- return AGESA_UNSUPPORTED;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/**********************************************************************</span><br><span style="color: hsl(0, 100%, 40%);">- * Interface service call: AmdGet2DDataEye</span><br><span style="color: hsl(0, 100%, 40%);">- **********************************************************************/</span><br><span style="color: hsl(0, 100%, 40%);">-AGESA_STATUS</span><br><span style="color: hsl(0, 100%, 40%);">-AmdGet2DDataEye (</span><br><span style="color: hsl(0, 100%, 40%);">- IN OUT AMD_GET_DATAEYE *AmdGetDataEye</span><br><span style="color: hsl(0, 100%, 40%);">- )</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- MODULE_ENTRY Dispatcher = agesa_get_dispatcher();</span><br><span style="color: hsl(0, 100%, 40%);">- AmdGetDataEye->StdHeader.Func = AMD_GET_2D_DATA_EYE;</span><br><span style="color: hsl(0, 100%, 40%);">- if (!Dispatcher) return AGESA_UNSUPPORTED;</span><br><span style="color: hsl(0, 100%, 40%);">- return Dispatcher(AmdGetDataEye);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-#endif /* IS_ENABLED(CONFIG_VENDORCODE_FULL_SUPPORT) */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28090">change 28090</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28090"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id91e76282509743070e34c02082d3f3f46a14059 </div>
<div style="display:none"> Gerrit-Change-Number: 28090 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>