[coreboot-gerrit] Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 )

Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here
......................................................................


Patch Set 63:

(4 comments)

https://review.coreboot.org/#/c/21437/63/util/ifdtool/ifdtool.c
File util/ifdtool/ifdtool.c:

https://review.coreboot.org/#/c/21437/63/util/ifdtool/ifdtool.c@188
PS63, Line 188: 		printf("Peculiar firmware descriptor, assuming Ibex Peak compatibility.\n");
line over 80 characters


https://review.coreboot.org/#/c/21437/63/util/ifdtool/ifdtool.c@197
PS63, Line 197: 		printf("Peculiar firmware descriptor, assuming Wildcat Point compatibility.\n");
line over 80 characters


https://review.coreboot.org/#/c/21437/63/util/ifdtool/ifdtool.c@1650
PS63, Line 1650: 		fpsba_t* fpsba = find_fpsba(image, size);
"foo* bar" should be "foo *bar"


https://review.coreboot.org/#/c/21437/63/util/ifdtool/ifdtool.c@1651
PS63, Line 1651: 		fmsba_t* fmsba = find_fmsba(image, size);
"foo* bar" should be "foo *bar"



-- 
To view, visit https://review.coreboot.org/21437
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a
Gerrit-Change-Number: 21437
Gerrit-PatchSet: 63
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Stefan Tauner <stefan.tauner at gmx.at>
Gerrit-Comment-Date: Mon, 13 Aug 2018 06:54:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180813/336928a2/attachment.html>