<p><a href="https://review.coreboot.org/21437">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/21437/63/util/ifdtool/ifdtool.c">File util/ifdtool/ifdtool.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21437/63/util/ifdtool/ifdtool.c@188">Patch Set #63, Line 188:</a> <code style="font-family:monospace,monospace">          printf("Peculiar firmware descriptor, assuming Ibex Peak compatibility.\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21437/63/util/ifdtool/ifdtool.c@197">Patch Set #63, Line 197:</a> <code style="font-family:monospace,monospace">            printf("Peculiar firmware descriptor, assuming Wildcat Point compatibility.\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21437/63/util/ifdtool/ifdtool.c@1650">Patch Set #63, Line 1650:</a> <code style="font-family:monospace,monospace">              fpsba_t* fpsba = find_fpsba(image, size);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21437/63/util/ifdtool/ifdtool.c@1651">Patch Set #63, Line 1651:</a> <code style="font-family:monospace,monospace">           fmsba_t* fmsba = find_fmsba(image, size);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"foo* bar" should be "foo *bar"</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/21437">change 21437</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21437"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a </div>
<div style="display:none"> Gerrit-Change-Number: 21437 </div>
<div style="display:none"> Gerrit-PatchSet: 63 </div>
<div style="display:none"> Gerrit-Owner: Bill XIE <persmule@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Nicola Corna <nicola@corna.info> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Stefan Tauner <stefan.tauner@gmx.at> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 13 Aug 2018 06:54:50 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>